You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Biao Liu (Jira)" <ji...@apache.org> on 2023/03/03 08:41:00 UTC
[jira] [Commented] (FLINK-31167) Verify that no exclusions were erroneously added to the japicmp plugin
[ https://issues.apache.org/jira/browse/FLINK-31167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696081#comment-17696081 ]
Biao Liu commented on FLINK-31167:
----------------------------------
Hi [~mapohl] , sorry for the late response.
{quote} wouldn't we be more stricter by throwing an UnsupportedOperationException as the default behavior of the deprecated method implementation?
{quote}
I think it's considerable choice. There is only one scenario i'm worrying about. If someone implements a new {{{}OutputFormat{}}}, and the IDE does not generate the {{open}} method automatically somehow. The codes would pass the compiling but fail in runtime. It's not so friendly. So I prefer the less stricter choice a bit. What do you think?
> Verify that no exclusions were erroneously added to the japicmp plugin
> ----------------------------------------------------------------------
>
> Key: FLINK-31167
> URL: https://issues.apache.org/jira/browse/FLINK-31167
> Project: Flink
> Issue Type: Sub-task
> Reporter: Matthias Pohl
> Assignee: Matthias Pohl
> Priority: Major
>
> Verify that no exclusions were erroneously added to the japicmp plugin that break compatibility guarantees. Check the exclusions for the japicmp-maven-plugin in the root pom (see [apache/flink:pom.xml:2175ff|https://github.com/apache/flink/blob/3856c49af77601cf7943a5072d8c932279ce46b4/pom.xml#L2175] for exclusions that:
> * For minor releases: break source compatibility for {{@Public}} APIs
> * For patch releases: break source/binary compatibility for {{@Public}}/{{@PublicEvolving}} APIs
> Any such exclusion must be properly justified, in advance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)