You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/09/19 23:47:11 UTC
[PR] chore(frontend): remove the dead link-breakpoint plumbing [texera]
aglinxinyuan opened a new pull request, #8615:
URL: https://github.com/apache/texera/pull/8615
### What changes were proposed in this PR?
Removes the plumbing left behind when the link-breakpoint feature was deleted from the UI. None of these streams can emit — there is no `.next()` on any of them anywhere in production, so the getters hand out streams that never fire and `linksWithBreakpoints` is permanently empty. Pure deletion, no behaviour change: **−100 lines**.
### History
| | |
| --- | --- |
| **Introduced by** | the original breakpoint implementation, commit `f80c9a43db` (2020-03-29) — predates the PR workflow |
| **Usage removed by** | #2392 (2024-02-19) — "Remove breakpoint feature" deleted `setLinkBreakpoint` and the `breakpointChangeStream.next` producers. #3033 (2024-11-13) — "Remove Operator Group" then removed the last `jointLinkBreakpointShowStream.next` / `HideStream.next` calls |
Since #3033 there has been no producer at all.
| Removed | Where |
| --- | --- |
| `jointLinkBreakpointShowStream` / `HideStream` + their getters, and the `linkIDType` alias only they used | `joint-graph-wrapper.ts` |
| `linksWithBreakpoints` + `getLinkIDsWithBreakpoint` | `joint-graph-wrapper.ts` |
| `breakpointChangeStream` + `getBreakpointChangeStream`, and the `"setLinkBreakpoint"` / `"breakpointChangeStream"` entries in the restricted-method union | `workflow-graph.ts` |
| the merge operand | `workflow-action.service.ts` |
| `handleLinkBreakpointToggleEvents` + its call | `workflow-editor.component.ts` |
> Reviewer note — one guard collapses rather than disappearing. The `link:mouseleave` handler skipped `hideTools()` for links that had a breakpoint; since `getLinkIDsWithBreakpoint()` always returns empty, that branch was always taken, so the call is now unconditional. Same behaviour, one branch fewer. The doc comment above it, which explained the breakpoint exception, is updated to match.
> The `"setLinkBreakpoint"` union entry names a method that no longer exists — it is a string in a restricted-method union, not a call site.
> These picked up coverage in #7481 (2026-08-09) and #6586 (2026-07-20), which is why they look live; those tests poke the dead subjects directly through `(wrapper as any)` rather than exercising a feature.
### Any related issues, documentation, discussions?
Closes #8612
### How was this PR tested?
Existing tests only — this PR removes code and the tests that poked it.
From `frontend/`:
- `npx ng build` — **success**. This PR edits a component, so the AOT build is the gate that proves no template still binds to a removed member.
- `npx ng test --watch=false --include='**/joint-graph-wrapper.spec.ts' --include='**/workflow-graph.spec.ts' --include='**/workflow-editor.component.spec.ts'` — 251 tests pass across the three files.
- `yarn --cwd frontend format:ci` — clean.
Verification, re-runnable by a reviewer:
```
git grep -n "LinkBreakpoint\|breakpointChangeStream\|linksWithBreakpoints\|linkIDType"
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the dead link-breakpoint plumbing [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8615:
URL: https://github.com/apache/texera/pull/8615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the dead link-breakpoint plumbing [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8615:
URL: https://github.com/apache/texera/pull/8615#issuecomment-5746204069
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@PG1204`, `@yangzhang75`, `@kz930`
You can notify them by mentioning `@PG1204`, `@yangzhang75`, `@kz930` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the dead link-breakpoint plumbing [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8615:
URL: https://github.com/apache/texera/pull/8615#issuecomment-5746244498
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8615?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.78%. Comparing base ([`957b6c9`](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c26f986`](https://app.codecov.io/gh/apache/texera/commit/c26f986c36d2406535f09ef44b516748e49bd1c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8615 +/- ##
============================================
- Coverage 92.78% 92.78% -0.01%
Complexity 4902 4902
============================================
Files 1236 1236
Lines 52165 52150 -15
Branches 6411 6410 -1
============================================
- Hits 48402 48388 -14
Misses 2191 2191
+ Partials 1572 1571 -1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.78% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.63% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.20% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.59% <100.00%> (+<0.01%)` | :arrow_up: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.48% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8615/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [957b6c9](https://app.codecov.io/gh/apache/texera/commit/957b6c965640c07ace034eb9edcae53ef974324a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8615?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org