You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2016/02/23 21:05:13 UTC
Review Request 43895: Patch Upgrade: integrate API to POST new repo
version when registering new version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43895/
-----------------------------------------------------------
Review request for Ambari, Richard Zang and Yusaku Sako.
Bugs: AMBARI-15147
https://issues.apache.org/jira/browse/AMBARI-15147
Repository: ambari
Description
-------
On Register Version page, UI provides two ways to upload version definition file, both should POST new stack version.
1. Browse local files and then Upload file,
POST /api/v1/version_definitions
<?xml ... >
The equivalent curl call would look like so (the text/xml header is required):
curl -u admin:admin -H "Content-Type: text/xml" -X POST -d @ambari-server/src/test/resources/hbase_version_test.xml http://localhost:8080/api/v1/version_definitions
2. Enter the Url then click on "Read Version File" button,
POST /api/v1/version_definitions
{
"RepositoryVersions": {
"version_url": "http://somewhere/version-definition.xml"
}
}
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 190670a
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 4caf85f
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js ae67c7e
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 112ded8
ambari-web/app/mappers/repository_version_mapper.js c937678
ambari-web/app/styles/stack_versions.less 5490592
ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_box.hbs 84d7835
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 1ea0c66
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js d7e26e2
ambari-web/app/views/main/admin/stack_upgrade/versions_view.js 17010ba
Diff: https://reviews.apache.org/r/43895/diff/
Testing
-------
UT passed
Thanks,
Xi Wang
Re: Review Request 43895: Patch Upgrade: integrate API to POST new
repo version when registering new version
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43895/#review120421
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On Feb. 24, 2016, 12:08 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43895/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 12:08 a.m.)
>
>
> Review request for Ambari, Richard Zang and Yusaku Sako.
>
>
> Bugs: AMBARI-15147
> https://issues.apache.org/jira/browse/AMBARI-15147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On Register Version page, UI provides two ways to upload version definition file, both should POST new stack version.
>
> 1. Browse local files and then Upload file,
>
> POST /api/v1/version_definitions
> <?xml ... >
>
> The equivalent curl call would look like so (the text/xml header is required):
>
> curl -u admin:admin -H "Content-Type: text/xml" -X POST -d @ambari-server/src/test/resources/hbase_version_test.xml http://localhost:8080/api/v1/version_definitions
>
>
> 2. Enter the Url then click on "Read Version File" button,
>
> POST /api/v1/version_definitions
> {
> "RepositoryVersions": {
> "version_url": "http://somewhere/version-definition.xml"
> }
> }
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 190670a
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 0dc10c1
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js ae67c7e
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 112ded8
> ambari-web/app/mappers/repository_version_mapper.js c937678
> ambari-web/app/styles/stack_versions.less 5490592
> ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_box.hbs 84d7835
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 1ea0c66
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js d7e26e2
>
> Diff: https://reviews.apache.org/r/43895/diff/
>
>
> Testing
> -------
>
> UT passed
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 43895: Patch Upgrade: integrate API to POST new
repo version when registering new version
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43895/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 4:08 p.m.)
Review request for Ambari, Richard Zang and Yusaku Sako.
Bugs: AMBARI-15147
https://issues.apache.org/jira/browse/AMBARI-15147
Repository: ambari
Description
-------
On Register Version page, UI provides two ways to upload version definition file, both should POST new stack version.
1. Browse local files and then Upload file,
POST /api/v1/version_definitions
<?xml ... >
The equivalent curl call would look like so (the text/xml header is required):
curl -u admin:admin -H "Content-Type: text/xml" -X POST -d @ambari-server/src/test/resources/hbase_version_test.xml http://localhost:8080/api/v1/version_definitions
2. Enter the Url then click on "Read Version File" button,
POST /api/v1/version_definitions
{
"RepositoryVersions": {
"version_url": "http://somewhere/version-definition.xml"
}
}
Diffs (updated)
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 190670a
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 0dc10c1
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js ae67c7e
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 112ded8
ambari-web/app/mappers/repository_version_mapper.js c937678
ambari-web/app/styles/stack_versions.less 5490592
ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_box.hbs 84d7835
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 1ea0c66
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js d7e26e2
Diff: https://reviews.apache.org/r/43895/diff/
Testing
-------
UT passed
Thanks,
Xi Wang
Re: Review Request 43895: Patch Upgrade: integrate API to POST new
repo version when registering new version
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43895/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 3:46 p.m.)
Review request for Ambari, Richard Zang and Yusaku Sako.
Bugs: AMBARI-15147
https://issues.apache.org/jira/browse/AMBARI-15147
Repository: ambari
Description
-------
On Register Version page, UI provides two ways to upload version definition file, both should POST new stack version.
1. Browse local files and then Upload file,
POST /api/v1/version_definitions
<?xml ... >
The equivalent curl call would look like so (the text/xml header is required):
curl -u admin:admin -H "Content-Type: text/xml" -X POST -d @ambari-server/src/test/resources/hbase_version_test.xml http://localhost:8080/api/v1/version_definitions
2. Enter the Url then click on "Read Version File" button,
POST /api/v1/version_definitions
{
"RepositoryVersions": {
"version_url": "http://somewhere/version-definition.xml"
}
}
Diffs (updated)
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 190670a
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 0dc10c1
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js ae67c7e
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 112ded8
ambari-web/app/mappers/repository_version_mapper.js c937678
ambari-web/app/styles/stack_versions.less 5490592
ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_box.hbs 84d7835
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 1ea0c66
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js d7e26e2
ambari-web/app/views/main/admin/stack_upgrade/versions_view.js 17010ba
Diff: https://reviews.apache.org/r/43895/diff/
Testing
-------
UT passed
Thanks,
Xi Wang