You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jo...@apache.org on 2017/01/20 01:15:21 UTC

[12/15] mesos git commit: Windows: Added GC tests to the build.

Windows: Added GC tests to the build.

These tests are fixed by the fix to `os::rmdir` in review #55327.
The tests were failing to delete sandbox folders when the sandbox
was deleted before deleting the symlink to the sandbox.

Review: https://reviews.apache.org/r/55328/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/08e5cd25
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/08e5cd25
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/08e5cd25

Branch: refs/heads/master
Commit: 08e5cd2580a142977b2d8a3abf2a70a398147f01
Parents: 5b52217
Author: Alex Clemmer <cl...@gmail.com>
Authored: Wed Jan 18 14:59:17 2017 -0800
Committer: Joseph Wu <jo...@apache.org>
Committed: Thu Jan 19 17:04:57 2017 -0800

----------------------------------------------------------------------
 src/tests/gc_tests.cpp | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/08e5cd25/src/tests/gc_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/gc_tests.cpp b/src/tests/gc_tests.cpp
index c4841e8..d9776b6 100644
--- a/src/tests/gc_tests.cpp
+++ b/src/tests/gc_tests.cpp
@@ -259,7 +259,7 @@ class GarbageCollectorIntegrationTest : public MesosTest {};
 
 // This test ensures that garbage collection removes
 // the slave working directory after a slave restart.
-TEST_F_TEMP_DISABLED_ON_WINDOWS(GarbageCollectorIntegrationTest, Restart)
+TEST_F(GarbageCollectorIntegrationTest, Restart)
 {
   Try<Owned<cluster::Master>> master = StartMaster();
   ASSERT_SOME(master);
@@ -373,9 +373,7 @@ TEST_F_TEMP_DISABLED_ON_WINDOWS(GarbageCollectorIntegrationTest, Restart)
 }
 
 
-TEST_F_TEMP_DISABLED_ON_WINDOWS(
-    GarbageCollectorIntegrationTest,
-    ExitedFramework)
+TEST_F(GarbageCollectorIntegrationTest, ExitedFramework)
 {
   Try<Owned<cluster::Master>> master = StartMaster();
   ASSERT_SOME(master);
@@ -495,7 +493,7 @@ TEST_F_TEMP_DISABLED_ON_WINDOWS(
 }
 
 
-TEST_F_TEMP_DISABLED_ON_WINDOWS(GarbageCollectorIntegrationTest, ExitedExecutor)
+TEST_F(GarbageCollectorIntegrationTest, ExitedExecutor)
 {
   Try<Owned<cluster::Master>> master = StartMaster();
   ASSERT_SOME(master);
@@ -605,7 +603,7 @@ TEST_F_TEMP_DISABLED_ON_WINDOWS(GarbageCollectorIntegrationTest, ExitedExecutor)
 }
 
 
-TEST_F_TEMP_DISABLED_ON_WINDOWS(GarbageCollectorIntegrationTest, DiskUsage)
+TEST_F(GarbageCollectorIntegrationTest, DiskUsage)
 {
   Try<Owned<cluster::Master>> master = StartMaster();
   ASSERT_SOME(master);
@@ -729,7 +727,7 @@ TEST_F_TEMP_DISABLED_ON_WINDOWS(GarbageCollectorIntegrationTest, DiskUsage)
 // This test verifies that the launch of new executor will result in
 // an unschedule of the framework work directory created by an old
 // executor.
-TEST_F_TEMP_DISABLED_ON_WINDOWS(GarbageCollectorIntegrationTest, Unschedule)
+TEST_F(GarbageCollectorIntegrationTest, Unschedule)
 {
   Try<Owned<cluster::Master>> master = StartMaster();
   ASSERT_SOME(master);