You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:07:12 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request #620: GUACAMOLE-680: Do not immediately re-authenticate after logout.
mike-jumper opened a new pull request #620:
URL: https://github.com/apache/guacamole-client/pull/620
As discussed in #573, this change adds an intermediate "you have been logged out" message that displays after the user manually logs out, allowing the user to _choose_ to re-authenticate when ready:
This prevents the user from being immediately signed back in when SSO is involved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #620: GUACAMOLE-680: Do not immediately re-authenticate after logout.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #620:
URL: https://github.com/apache/guacamole-client/pull/620#discussion_r651328002
##########
File path: guacamole/src/main/frontend/src/app/auth/service/authenticationService.js
##########
@@ -252,6 +252,24 @@ angular.module('auth').factory('authenticationService', ['$injector',
};
+ /**
+ * Makes a request to revoke an authentication token using the token REST
+ * API endpoint, returning a promise succeeds only if the token was
Review comment:
There's a second occurrence of this in the documentation of the function that this was copied from. I've corrected both in a fresh commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #620: GUACAMOLE-680: Do not immediately re-authenticate after logout.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #620:
URL: https://github.com/apache/guacamole-client/pull/620#discussion_r651326534
##########
File path: guacamole/src/main/frontend/src/app/auth/service/authenticationService.js
##########
@@ -252,6 +252,24 @@ angular.module('auth').factory('authenticationService', ['$injector',
};
+ /**
+ * Makes a request to revoke an authentication token using the token REST
+ * API endpoint, returning a promise succeeds only if the token was
Review comment:
Oops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #620: GUACAMOLE-680: Do not immediately re-authenticate after logout.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #620:
URL: https://github.com/apache/guacamole-client/pull/620#discussion_r651012690
##########
File path: guacamole/src/main/frontend/src/app/auth/service/authenticationService.js
##########
@@ -252,6 +252,24 @@ angular.module('auth').factory('authenticationService', ['$injector',
};
+ /**
+ * Makes a request to revoke an authentication token using the token REST
+ * API endpoint, returning a promise succeeds only if the token was
Review comment:
_that_ succeeds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #620: GUACAMOLE-680: Do not immediately re-authenticate after logout.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #620:
URL: https://github.com/apache/guacamole-client/pull/620#issuecomment-861042102
> Looks good to me, one question -- Does this mean for things like [GUACAMOLE-519](https://issues.apache.org/jira/browse/GUACAMOLE-519) that we would just use the following handler hook to do the necessary operations?
>
> ```js
> $scope.on('guacLogout', <function stuff>)
> ```
For anything that absolutely must be done client-side, yes. Otherwise, it would be better to rely on [the server-side `invalidate()` function of `UserContext`](http://guacamole.apache.org/doc/1.3.0/guacamole-ext/org/apache/guacamole/net/auth/UserContext.html#invalidate--).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman merged pull request #620: GUACAMOLE-680: Do not immediately re-authenticate after logout.
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #620:
URL: https://github.com/apache/guacamole-client/pull/620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] knacktim commented on pull request #620: GUACAMOLE-680: Do not immediately re-authenticate after logout.
Posted by GitBox <gi...@apache.org>.
knacktim commented on pull request #620:
URL: https://github.com/apache/guacamole-client/pull/620#issuecomment-860687456
Looks good to me, one question -- Does this mean for things like [GUACAMOLE-519](https://issues.apache.org/jira/browse/GUACAMOLE-519) that we would just use the following handler hook to do the necessary operations?
```javascript
$scope.on('guacLogout', <function stuff>)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org