You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/23 13:38:23 UTC
[GitHub] [iceberg] rymurr opened a new pull request #1369: [Python] add python 3.7 and 3.8 to CI
rymurr opened a new pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1369: [Python] add python 3.7 and 3.8 to CI
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369#issuecomment-679430752
Thanks @rymurr! Merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1369: [Python] add python 3.7 and 3.8 to CI
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369#discussion_r475762670
##########
File path: .travis.yml
##########
@@ -45,10 +45,28 @@ matrix:
- $HOME/.gradle/wrapper/
- language: python
- python: 3.6
+ python:
+ - 3.6
before_script:
- cd python
- pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.7
+ before_script:
+ - cd python
+ - pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.8
Review comment:
It looks fine with all 3 separate, but the 3.8 config lists both 3.6 and 3.7 as well. Should those be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1369: [Python] add python 3.7 and 3.8 to CI
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1369: [Python] add python 3.7 and 3.8 to CI
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369#discussion_r475271094
##########
File path: .travis.yml
##########
@@ -45,10 +45,28 @@ matrix:
- $HOME/.gradle/wrapper/
- language: python
- python: 3.6
+ python:
+ - 3.6
before_script:
- cd python
- pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.7
+ before_script:
+ - cd python
+ - pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.8
Review comment:
If all of these have the same before_scripts can't we just do
```
python:
-3.6
-3.7
-3.8
before_script:
script:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr commented on a change in pull request #1369: [Python] add python 3.7 and 3.8 to CI
Posted by GitBox <gi...@apache.org>.
rymurr commented on a change in pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369#discussion_r475770619
##########
File path: .travis.yml
##########
@@ -45,10 +45,28 @@ matrix:
- $HOME/.gradle/wrapper/
- language: python
- python: 3.6
+ python:
+ - 3.6
before_script:
- cd python
- pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.7
+ before_script:
+ - cd python
+ - pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.8
Review comment:
yes, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr commented on a change in pull request #1369: [Python] add python 3.7 and 3.8 to CI
Posted by GitBox <gi...@apache.org>.
rymurr commented on a change in pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369#discussion_r475411356
##########
File path: .travis.yml
##########
@@ -45,10 +45,28 @@ matrix:
- $HOME/.gradle/wrapper/
- language: python
- python: 3.6
+ python:
+ - 3.6
before_script:
- cd python
- pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.7
+ before_script:
+ - cd python
+ - pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.8
Review comment:
I thought so as well. Travis seems to only run one python in that case.
Compare yesterdays travis run:
https://travis-ci.org/github/apache/iceberg/builds/720376892
To today's with the duplicate code removed:
https://travis-ci.org/github/apache/iceberg/builds/720565051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1369: [Python] add python 3.7 and 3.8 to CI
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369#discussion_r475781573
##########
File path: .travis.yml
##########
@@ -45,10 +45,28 @@ matrix:
- $HOME/.gradle/wrapper/
- language: python
- python: 3.6
+ python:
+ - 3.6
before_script:
- cd python
- pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.7
+ before_script:
+ - cd python
+ - pip install -e .[dev]
+ - pip install -U tox-travis
+ script: tox
+ - language: python
+ python:
+ - 3.8
Review comment:
Travis is a mystery sometimes :) I wouldn't waste time figuring it out since the current version works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org