You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/02/05 07:59:30 UTC

[GitHub] [commons-compress] PeterAlfreadLee opened a new pull request #92: COMPRESS-477 : "open when actually needed" for MultiReadOnlySeekableByteChannel

PeterAlfreadLee opened a new pull request #92: COMPRESS-477 : "open when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92
 
 
   Please refer (#90)[https://github.com/apache/commons-compress/pull/90]
   
   When I was adding zip64 support for split zip, I encountered a problem : 
   When adding testcases in `Zip64SupportIT`, I created a split zip with 10,000+ split segments. Then I found that I was unable to unzip it because there would be too many open files when extracting it. We can oepn the files when actually needed and therefore we can successfully extract such split zips with great amount of segments.
   
   I have set a threshold of 20 in `MultiReadOnlySeekableByteChannel`. The "open when actually needed" procedure will only work when the number of split segments is greater than the threshold.
   
   Actually this is a pretty rare case cause most split zips would not have too many segments. So you can decide whether to merge this PR or not. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] coveralls commented on issue #92: COMPRESS-503 : "open when actually needed" for MultiReadOnlySeekableByteChannel

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #92: COMPRESS-503 : "open when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92#issuecomment-582299600
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28537848/badge)](https://coveralls.io/builds/28537848)
   
   Coverage decreased (-0.2%) to 86.754% when pulling **7ffc7a87236be2fd72b663f2735370a2d183494a on PeterAlfreadLee:COMPRESS-477-improve** into **151e0fb3fa241887ae3192cc92c572401c6a182b on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] PeterAlfreadLee commented on issue #92: COMPRESS-477 : "open when actually needed" for MultiReadOnlySeekableByteChannel

Posted by GitBox <gi...@apache.org>.
PeterAlfreadLee commented on issue #92: COMPRESS-477 : "open when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92#issuecomment-582290001
 
 
   Sure. I will add a new JIRA issue and modify the name of this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] coveralls edited a comment on issue #92: COMPRESS-503 : "open when actually needed" for MultiReadOnlySeekableByteChannel

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #92: COMPRESS-503 : "open when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92#issuecomment-582299600
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28537848/badge)](https://coveralls.io/builds/28537848)
   
   Coverage decreased (-0.2%) to 86.779% when pulling **7ffc7a87236be2fd72b663f2735370a2d183494a on PeterAlfreadLee:COMPRESS-477-improve** into **151e0fb3fa241887ae3192cc92c572401c6a182b on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] bodewig commented on issue #92: COMPRESS-477 : "open when actually needed" for MultiReadOnlySeekableByteChannel

Posted by GitBox <gi...@apache.org>.
bodewig commented on issue #92: COMPRESS-477 : "open when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92#issuecomment-582289566
 
 
   @PeterAlfreadLee I think it would be good to track this as a separate JIRA issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services