You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jspwiki.apache.org by GitBox <gi...@apache.org> on 2021/09/10 15:58:25 UTC

[GitHub] [jspwiki] juanpablo-santos commented on pull request #47: JSPWIKI-1148 - Avoid File Stream

juanpablo-santos commented on pull request #47:
URL: https://github.com/apache/jspwiki/pull/47#issuecomment-917016622


   Hi @arturobernalg ,
   
   apologies for the long delay looking at this PR. I'm +1 on merging it, however, would you mind pls rebasing with latest commits? 
   
   As for the signature change, that method is package-protected and seems to be used only by the `loadWebAppProps` method on the same class, and handled by its `try..catch` block, so it shouldn't be a big deal..
   
   
   best regards,
   juan pablo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org