You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/23 10:18:01 UTC

[GitHub] [shardingsphere] TeslaCN opened a new pull request #15587: Avoid get unused service in InsertClauseShardingConditionEngine

TeslaCN opened a new pull request #15587:
URL: https://github.com/apache/shardingsphere/pull/15587


   Related to #10626.
   
   We never use `now()` in insertions, but the overhead of getting `DatetimeService` is always present.
   
   https://github.com/apache/shardingsphere/blob/af1c0fc750a8a1ef57d843d0bfbed5dde673bba7/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/impl/InsertClauseShardingConditionEngine.java#L87-L103
   
   ![image](https://user-images.githubusercontent.com/20503072/155299634-fd8d46d7-1649-429b-a77b-2c189f27d4d5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero merged pull request #15587: Avoid get unused service in InsertClauseShardingConditionEngine

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #15587:
URL: https://github.com/apache/shardingsphere/pull/15587


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org