You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "gmitter-ef (via GitHub)" <gi...@apache.org> on 2025/11/10 13:27:17 UTC

[I] [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution (hop)

gmitter-ef opened a new issue, #5982:
URL: https://github.com/apache/hop/issues/5982

   ### Apache Hop version?
   
   2.15
   
   ### Java version?
   
   OpenJDK 17
   
   ### Operating system
   
   Windows
   
   ### What happened?
   
   An outer workflow calls an inner workflow which calls a pipeline.
   The pipeline fails which is handled via a "Abort" transform.
   The inner workflow recognizes the failing pipeline correctly via the "Failure hop" and calls an "Abort workflow" action.
   The outer worklfow then does NOT recognize the failure of the inner workflow and follows the "Success hop" instead of the "Failure hop".
   
   The wrong behaviour occurs if:
   - an action SITS BETWEEN the failing pipeline and the "Abort workflow" action.
   - in the "Abort workflow" action, "Always log rows" is CHECKED
   
   If the "Abort workflow" action is DIRECTLY attached to the failing pipeline, the correct behaviour is shown, irrespective of the status of the checkbox.
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Hop Gui, Component: Actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution (hop)

Posted by "gmitter-ef (via GitHub)" <gi...@apache.org>.
gmitter-ef commented on issue #5982:
URL: https://github.com/apache/hop/issues/5982#issuecomment-3520354374

   @hansva 
   
   > original ticket that was raised for this feature: https://issues.apache.org/jira/browse/HOP-3921
   
   Is this not accessible anymore?
   
   > Ah, upon further investigation, it actually does what it is supposed to do
   
   > And even if that was the case. Then it should always just abort the workflow and mark it as a success whether the previous action succeeded or failed.
   
   Are these two statements not contradictory? My understanding is that (documentation provided) checking or unchecking the checkbox could/should have an influence on marking the workflow as success or failed, but just adding an action before the "Abort workflow" should not change the result from "failed" to "success".
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #5982:
URL: https://github.com/apache/hop/issues/5982#issuecomment-3512457517

   Yup, this is not what that option was supposed to do.
   It is indeed not setting the workflow as failed, but it is keeping the status from the previous action.
   
   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #5982:
URL: https://github.com/apache/hop/issues/5982#issuecomment-5103936355

   Removed the original feature and went back to what the actual goal was.
   Added an option to change the logging level of the message being printed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution (hop)

Posted by "gmitter-ef (via GitHub)" <gi...@apache.org>.
gmitter-ef commented on issue #5982:
URL: https://github.com/apache/hop/issues/5982#issuecomment-3526662267

   Thanks for this verification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva closed issue #5982: [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution
URL: https://github.com/apache/hop/issues/5982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #5982:
URL: https://github.com/apache/hop/issues/5982#issuecomment-3522842072

   Currently it seems it is retaining the state from the previous action (which is wrong) so there is an issue 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Checked "Always log rows" in "Abort workflow" action leads to wrong flow of execution (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #5982:
URL: https://github.com/apache/hop/issues/5982#issuecomment-3512527232

   Ah, upon further investigation, it actually does what it is supposed to do, but the documentation is nonexistent.
   Going to the original ticket that was raised for this feature: https://issues.apache.org/jira/browse/HOP-3921
   
   When aborting a pipeline, you have multiple options:
   - Abort the run, but do not mark it as an error
   - Abort the run and mark it as an error
   
   It seems that the request was to have the same options in a workflow. But I am wondering when this would be useful. The only use case I can think of is when a workflow is running in parallel and you want to stop the other running actions but not mark the workflow as failed. 
   
   And even if that was the case. Then it should always just abort the workflow and mark it as a success whether the previous action succeeded or failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org