You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/06/18 07:26:11 UTC

[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #273: GUACAMOLE-1053: guacd segfaults if user actively presses keys during RDP disconnect

mike-jumper commented on a change in pull request #273:
URL: https://github.com/apache/guacamole-server/pull/273#discussion_r442018902



##########
File path: src/protocols/rdp/client.c
##########
@@ -155,6 +157,12 @@ int guac_client_init(guac_client* client, int argc, char** argv) {
     pthread_mutexattr_settype(&(rdp_client->attributes),
             PTHREAD_MUTEX_RECURSIVE);
 
+    /* Initalize the lock */
+    pthread_rwlockattr_init(&lock_attributes);
+    pthread_rwlockattr_setpshared(&lock_attributes, PTHREAD_PROCESS_SHARED);

Review comment:
       Does this lock need `PTHREAD_PROCESS_SHARED`? I don't believe instances of this lock will be shared across different processes, just among threads of the same process.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org