You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/07/20 04:27:55 UTC
[GitHub] [spark] cxzl25 opened a new pull request, #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
cxzl25 opened a new pull request, #42085:
URL: https://github.com/apache/spark/pull/42085
### What changes were proposed in this pull request?
Remove `TaskPagedTable`
### Why are the changes needed?
In [SPARK-21809](https://issues.apache.org/jira/browse/SPARK-21809), we introduced `stagespage-template.html` to show the running status of Stage.
`TaskPagedTable` is no longer effective, but there are still many PRs updating related codes.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cxzl25 commented on pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1655124969
> Could you please attach one or more screenshots in the description?
### PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #42085: [SPARK-44490][WEBUI] Remove unused `TaskPagedTable` in StagePage
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak closed pull request #42085: [SPARK-44490][WEBUI] Remove unused `TaskPagedTable` in StagePage
URL: https://github.com/apache/spark/pull/42085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cxzl25 commented on pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1655284142
> Could you attach another screenshot showing a task table which consists of multiple pages to verify it works with pagenation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1659480750
Hi @cxzl25, would you please rebase the master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1655235223
@cxzl25 Could you attach another screenshot showing a task table which consists of multiple pages to verify it works with pagenation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a diff in pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on code in PR #42085:
URL: https://github.com/apache/spark/pull/42085#discussion_r1277234850
##########
core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala:
##########
@@ -209,32 +204,24 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
val dagViz = UIUtils.showDagVizForStage(stageId, stageGraph)
val currentTime = System.currentTimeMillis()
- val taskTable = try {
- val _taskTable = new TaskPagedTable(
- stageData,
- UIUtils.prependBaseUri(request, parent.basePath) +
- s"/stages/stage/?id=${stageId}&attempt=${stageAttemptId}",
- pageSize = taskPageSize,
- sortColumn = taskSortColumn,
- desc = taskSortDesc,
- store = parent.store
- )
- _taskTable
- } catch {
- case e @ (_ : IllegalArgumentException | _ : IndexOutOfBoundsException) =>
- null
- }
val content =
summary ++
dagViz ++ <div id="showAdditionalMetrics"></div> ++
makeTimeline(
// Only show the tasks in the table
- Option(taskTable).map({ taskPagedTable =>
+ () => {
+ val taskDataSource = new TaskDataSource(
Review Comment:
Can we also remove `TaskDataSource`? It seems to be used only in `TaskPagedTable`.
##########
core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala:
##########
@@ -258,6 +245,8 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
if (!TIMELINE_ENABLED) return Seq.empty[Node]
+ val tasks = tasksFunc()
Review Comment:
Thank you. It's reasonable to avoid the calsulation if the timeline feature is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1655141272
cc @sarutak @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1655049364
Could you please attach one or more screenshots in the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #42085: [SPARK-44490][WEBUI] Remove unused `TaskPagedTable` in StagePage
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1659658351
Merging to `master`.
Thank you @cxzl25 and all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1654999701
also cc @yaooqinn FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cxzl25 commented on pull request #42085: [SPARK-44490][WEBUI] Remove `TaskPagedTable` in StagePage
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #42085:
URL: https://github.com/apache/spark/pull/42085#issuecomment-1654998099
@LuciferYang Please help to review, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org