[GitHub] reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger

[GitBox <gi...@apache.org>]

reddycharan commented on a change in pull request #1201: ISSUE #570: Entrylog per ledger
URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r171019871
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
 ##########
 @@ -110,11 +150,15 @@ public long getFileChannelPosition() {
      * @throws IOException if the write or sync operation fails.
      */
     public void flush(boolean shouldForceWrite) throws IOException {
+        flush(shouldForceWrite, false);
+    }
+
+    public void flush(boolean shouldForceWrite, boolean forceMetadata) throws IOException {
 
 Review comment:
   Call Hierarchy of this method : 
   
   flush(boolean, boolean) : void - org.apache.bookkeeper.bookie.BufferedChannel
   	flush(boolean) : void - org.apache.bookkeeper.bookie.BufferedChannel
   	flushCurrentLog(BufferedLogChannel, boolean) : void - org.apache.bookkeeper.bookie.EntryLogger

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services