You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "jasonbu (via GitHub)" <gi...@apache.org> on 2024/07/24 04:10:41 UTC

[PR] up_backtrace: fix maybe backtrace the exiting thread [nuttx]

jasonbu opened a new pull request, #12754:
URL: https://github.com/apache/nuttx/pull/12754

   ## Summary
   when trying to show information at task quit and thread still running, try dump callstack found maybe some problem.
   Need this patch to solve dump exiting thread callstack. need another patch to fix dump running thread stack.
   
   ## Impact
   Can dump the exiting thread after patch.
   
   ## Testing
   CI & qemu-armv7a & SMP armv7a board.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] up_backtrace: fix maybe backtrace the exiting thread [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12754:
URL: https://github.com/apache/nuttx/pull/12754#discussion_r1690746083


##########
sched/sched/sched_backtrace.c:
##########
@@ -44,16 +44,21 @@
 int sched_backtrace(pid_t tid, FAR void **buffer, int size, int skip)

Review Comment:
   ```suggestion
   int sched_backtrace(pid_t tid, FAR void **buffer, int size, int skip)
   {
     FAR struct tcb_s *rtcb;
     irqstate_t flags;
     int ret = 0;
       
     if (tid >= 0)
       {
         flags = enter_critical_section();
   
         rtcb = nxsched_get_tcb(tid);
         if (rtcb != NULL)
           {
             ret = up_backtrace(rtcb, buffer, size, skip);
           }
   
         leave_critical_section(flags);
       }
   
     return ret;
   }   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] up_backtrace: fix maybe backtrace the exiting thread [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12754:
URL: https://github.com/apache/nuttx/pull/12754


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org