You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by R-Rajkumar <gi...@git.apache.org> on 2014/10/07 10:34:58 UTC
[GitHub] stratos pull request: Review changes
GitHub user R-Rajkumar opened a pull request:
https://github.com/apache/stratos/pull/82
Review changes
* changing log.fatal() to log.warn()
* custom message to log.error(msg, e)
* license header to difference.rb in puppet module
* made obsoleted member expiry time configurable
* log.warn() when cluster monitor creation failed
* changing log.debug() to log.error() when cluster monitor not found, while receiving topology and health stats events
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/R-Rajkumar/stratos review-changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit 18d7d0b6ee361a73faf97bf313bcd56d4c00dcf1
Author: R-Rajkumar <rr...@gmail.com>
Date: 2014-10-07T08:04:24Z
licience added to difference.rb
commit 0517ad863b0eaa068282047234dfa0ca4dee1ccb
Author: R-Rajkumar <rr...@gmail.com>
Date: 2014-10-07T08:09:28Z
review changes
commit d89783195c390c02fb689c6adf346bea9545f88c
Author: R-Rajkumar <rr...@gmail.com>
Date: 2014-10-07T08:33:51Z
throwing exceptions with custom message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Review changes
Posted by R-Rajkumar <gi...@git.apache.org>.
Github user R-Rajkumar commented on a diff in the pull request:
https://github.com/apache/stratos/pull/82#discussion_r18512152
--- Diff: products/stratos/modules/distribution/src/main/conf/autoscaler.xml ---
@@ -38,8 +38,10 @@
<clientTimeout>300000</clientTimeout>
</stratosManager>
<member>
- <!-->member expiry timeout (time waited till activation) in ms<-->
- <expiryTimeout>900000</expiryTimeout>
+ <!-- this is the maximum time a member can be in pending member state -->
+ <pendingMemberExpiryTimeout>900000</pendingMemberExpiryTimeout>
+ <!-- this is the maximum time a member can bee in obsoleted member state -->
+ <obsoltedMemberExpiryTimeout>86400000</obsoltedMemberExpiryTimeout>
--- End diff --
This is fixed now. Thanks Imesh for pointing this out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Review changes
Posted by R-Rajkumar <gi...@git.apache.org>.
Github user R-Rajkumar closed the pull request at:
https://github.com/apache/stratos/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Review changes
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/82#discussion_r18511530
--- Diff: products/stratos/modules/distribution/src/main/conf/autoscaler.xml ---
@@ -38,8 +38,10 @@
<clientTimeout>300000</clientTimeout>
</stratosManager>
<member>
- <!-->member expiry timeout (time waited till activation) in ms<-->
- <expiryTimeout>900000</expiryTimeout>
+ <!-- this is the maximum time a member can be in pending member state -->
+ <pendingMemberExpiryTimeout>900000</pendingMemberExpiryTimeout>
+ <!-- this is the maximum time a member can bee in obsoleted member state -->
+ <obsoltedMemberExpiryTimeout>86400000</obsoltedMemberExpiryTimeout>
--- End diff --
Seems like we have a spelling mistake here: "obsoltedMemberExpiryTimeout"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---