You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jansule (via GitHub)" <gi...@apache.org> on 2023/06/02 09:40:46 UTC

[GitHub] [superset] jansule opened a new pull request, #24272: chore(deps): bump typescript to 4.8.4

jansule opened a new pull request, #24272:
URL: https://github.com/apache/superset/pull/24272

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This bumps `typescript` from `4.5.4` to `4.8.4`. `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` were upgraded to `5.42.1` to match the typescript version.
   
   New TSERRORs were fixed where possible. Unfortunately, I had to add a few `@ts-ignore`s here and there. Maybe someone with a deeper understanding of the code base is able to fix these errors properly.
   
   I decided to bump to typescript 4.8.4 as work related to https://github.com/apache/superset/discussions/21758 introduced an upgrade to this version anyways. In consultation with @villebro we decided to create a dedicated PR for this.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   Simply run the tests and build the application to see if any TSERRORs occur.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jansule commented on a diff in pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "jansule (via GitHub)" <gi...@apache.org>.
jansule commented on code in PR #24272:
URL: https://github.com/apache/superset/pull/24272#discussion_r1214241235


##########
superset-frontend/plugins/plugin-chart-word-cloud/src/chart/WordCloud.tsx:
##########
@@ -158,6 +158,7 @@ class WordCloud extends React.PureComponent<
   update() {
     const { data, encoding } = this.props;
 
+    // @ts-ignore

Review Comment:
   Sure, it's
   
   ```
   Argument of type 'Partial<DeriveEncoding<WordCloudEncodingConfig>>' is not assignable to parameter of type 'never'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jansule commented on pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "jansule (via GitHub)" <gi...@apache.org>.
jansule commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1680663222

   @EugeneTorap just rebased against current master. Locally, the build succeeded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(deps): bump typescript to 4.8.4 [superset]

Posted by "jansule (via GitHub)" <gi...@apache.org>.
jansule commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1855727402

   I'm not sure how to interpret the failing check https://github.com/apache/superset/actions/runs/7088616773/job/19419142631?pr=24272:
   
   ```
   ────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                         
       Running:  explore/visualizations/sankey.test.js                                         (31 of 53)
       Estimated: 18 seconds
     
     
       Visualization > Sankey
         ✓ should work (3946ms)
         ✓ should work with filter (2418ms)
     Error: The operation was canceled.
   ```
   
   I would be gratefule, if somebody could give me hints here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1659586438

   Hey @jansule! Can you merge master to your branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(deps): bump typescript to 4.8.4 [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1828323036

   @jansule sorry for missing this PR - would you be able to rebase this so we can get it merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jansule commented on a diff in pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "jansule (via GitHub)" <gi...@apache.org>.
jansule commented on code in PR #24272:
URL: https://github.com/apache/superset/pull/24272#discussion_r1214241235


##########
superset-frontend/plugins/plugin-chart-word-cloud/src/chart/WordCloud.tsx:
##########
@@ -158,6 +158,7 @@ class WordCloud extends React.PureComponent<
   update() {
     const { data, encoding } = this.props;
 
+    // @ts-ignore

Review Comment:
   Sure, its
   
   ```
   Argument of type 'Partial<DeriveEncoding<WordCloudEncodingConfig>>' is not assignable to parameter of type 'never'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(deps): bump typescript to 4.8.4 [superset]

Posted by "jansule (via GitHub)" <gi...@apache.org>.
jansule commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1838860519

   @villebro I just rebased against current master. Locally the build is passing (`docker build --target lean .`). I also clicked very briefly through the application and did not encounter issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jansule commented on pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "jansule (via GitHub)" <gi...@apache.org>.
jansule commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1678678250

   @EugeneTorap Sorry for the late reply. I will try to find time this week to rebase against current master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jansule commented on a diff in pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "jansule (via GitHub)" <gi...@apache.org>.
jansule commented on code in PR #24272:
URL: https://github.com/apache/superset/pull/24272#discussion_r1214246558


##########
superset-frontend/plugins/plugin-chart-table/src/utils/extent.ts:
##########
@@ -24,16 +24,16 @@ export default function extent<T = number | string | Date | undefined | null>(
   // eslint-disable-next-line no-restricted-syntax
   for (const value of values) {
     if (value !== null) {
-      if (min === undefined) {
+      if (min === undefined || min === null) {
         if (value !== undefined) {
           min = value;
           max = value;
         }
-      } else {
+      } else if (value !== undefined) {
         if (min > value) {
           min = value;
         }
-        if (max !== undefined) {
+        if (max !== undefined && max !== null) {

Review Comment:
   Done in https://github.com/apache/superset/pull/24272/commits/cbcc0eead2226cbd31a0627dcfb09bba0c1e42d6



##########
superset-frontend/plugins/plugin-chart-table/src/utils/extent.ts:
##########
@@ -24,16 +24,16 @@ export default function extent<T = number | string | Date | undefined | null>(
   // eslint-disable-next-line no-restricted-syntax
   for (const value of values) {
     if (value !== null) {
-      if (min === undefined) {
+      if (min === undefined || min === null) {

Review Comment:
   Done in https://github.com/apache/superset/pull/24272/commits/cbcc0eead2226cbd31a0627dcfb09bba0c1e42d6



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on a diff in pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #24272:
URL: https://github.com/apache/superset/pull/24272#discussion_r1214196143


##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -189,7 +189,8 @@ const config: ControlPanelConfig = {
           },
         ],
         [
-          hasGenericChartAxes && isAggMode
+          // removed && isAggMode as it is a function defined above. So this will always evaluate to true

Review Comment:
   let's remove this comment in the code and rather add it as comment here on GH
   ```suggestion
   ```



##########
superset-frontend/plugins/plugin-chart-table/src/utils/extent.ts:
##########
@@ -24,16 +24,16 @@ export default function extent<T = number | string | Date | undefined | null>(
   // eslint-disable-next-line no-restricted-syntax
   for (const value of values) {
     if (value !== null) {
-      if (min === undefined) {
+      if (min === undefined || min === null) {
         if (value !== undefined) {
           min = value;
           max = value;
         }
-      } else {
+      } else if (value !== undefined) {
         if (min > value) {
           min = value;
         }
-        if (max !== undefined) {
+        if (max !== undefined && max !== null) {

Review Comment:
   Maybe
   ```suggestion
           if (!isNil(max)) {
   ```



##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -217,7 +218,8 @@ const config: ControlPanelConfig = {
                 },
               }
             : null,
-          hasGenericChartAxes && isAggMode ? 'temporal_columns_lookup' : null,
+          // removed && isAggMode as it is a function defined above. So this will always evaluate to true

Review Comment:
   Same here
   ```suggestion
   ```



##########
superset-frontend/plugins/plugin-chart-word-cloud/src/chart/WordCloud.tsx:
##########
@@ -158,6 +158,7 @@ class WordCloud extends React.PureComponent<
   update() {
     const { data, encoding } = this.props;
 
+    // @ts-ignore

Review Comment:
   not a huge deal, but I'd be curious to understand what the error was here, do you have it handy?



##########
superset-frontend/plugins/plugin-chart-table/src/utils/extent.ts:
##########
@@ -24,16 +24,16 @@ export default function extent<T = number | string | Date | undefined | null>(
   // eslint-disable-next-line no-restricted-syntax
   for (const value of values) {
     if (value !== null) {
-      if (min === undefined) {
+      if (min === undefined || min === null) {

Review Comment:
   Maybe we could use `_.isNil` here?
   
   ```node
   let _ = require('lodash');
   > _.isNil(undefined)
   true
   > _.isNil(null)
   true
   > _.isNil(0)
   false
   > _.isNil('')
   false
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1573587849

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#24272](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f1767e7) into [master](https://app.codecov.io/gh/apache/superset/commit/1d9a761de5410fa1bd208bca4c78614779cf3064?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1d9a761) will **increase** coverage by `0.00%`.
   > The diff coverage is `46.15%`.
   
   > :exclamation: Current head f1767e7 differs from pull request most recent head cbcc0ee. Consider uploading reports for the commit cbcc0ee to get more accurate results
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #24272   +/-   ##
   =======================================
     Coverage   68.29%   68.29%           
   =======================================
     Files        1957     1957           
     Lines       75624    75625    +1     
     Branches     8223     8220    -3     
   =======================================
   + Hits        51649    51651    +2     
   - Misses      21867    21868    +1     
   + Partials     2108     2106    -2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `54.73% <46.15%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ore/src/chart/components/createLoadableRenderer.ts](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY2hhcnQvY29tcG9uZW50cy9jcmVhdGVMb2FkYWJsZVJlbmRlcmVyLnRz) | `100.00% <ø> (ø)` | |
   | [...ackages/superset-ui-switchboard/src/switchboard.ts](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktc3dpdGNoYm9hcmQvc3JjL3N3aXRjaGJvYXJkLnRz) | `100.00% <ø> (ø)` | |
   | [...ugin-chart-table/src/DataTable/hooks/useSticky.tsx](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL0RhdGFUYWJsZS9ob29rcy91c2VTdGlja3kudHN4) | `55.43% <ø> (ø)` | |
   | [...nd/plugins/plugin-chart-table/src/controlPanel.tsx](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `53.03% <0.00%> (ø)` | |
   | [...end/plugins/plugin-chart-table/src/utils/extent.ts](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL3V0aWxzL2V4dGVudC50cw==) | `0.00% <0.00%> (ø)` | |
   | [...ns/plugin-chart-word-cloud/src/chart/WordCloud.tsx](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtd29yZC1jbG91ZC9zcmMvY2hhcnQvV29yZENsb3VkLnRzeA==) | `0.00% <ø> (ø)` | |
   | [...preset-chart-xy/src/components/BoxPlot/BoxPlot.tsx](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL2NvbXBvbmVudHMvQm94UGxvdC9Cb3hQbG90LnRzeA==) | `0.00% <ø> (ø)` | |
   | [...hart-xy/src/components/ScatterPlot/ScatterPlot.tsx](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL2NvbXBvbmVudHMvU2NhdHRlclBsb3QvU2NhdHRlclBsb3QudHN4) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Modal/Modal.tsx](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `85.89% <ø> (ø)` | |
   | [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `9.09% <0.00%> (ø)` | |
   | ... and [4 more](https://app.codecov.io/gh/apache/superset/pull/24272?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1681075125

   Hey @michael-s-molina! Can you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on a diff in pull request #24272: chore(deps): bump typescript to 4.8.4

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #24272:
URL: https://github.com/apache/superset/pull/24272#discussion_r1214274432


##########
superset-frontend/plugins/plugin-chart-word-cloud/src/chart/WordCloud.tsx:
##########
@@ -158,6 +158,7 @@ class WordCloud extends React.PureComponent<
   update() {
     const { data, encoding } = this.props;
 
+    // @ts-ignore

Review Comment:
   Oh, I just noticed it's still a class component. Let's revisit this some day when it's migrated to a functional component.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(deps): bump typescript to 4.8.4 [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24272:
URL: https://github.com/apache/superset/pull/24272#issuecomment-1845668499

   Running CI 🤞


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(deps): bump typescript to 4.8.4 [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #24272:
URL: https://github.com/apache/superset/pull/24272


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org