You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/19 09:22:52 UTC
[GitHub] [ignite] korlov42 opened a new pull request #9018: IGNITE-14590 sort out the types/decimal and types/string directories
korlov42 opened a new pull request #9018:
URL: https://github.com/apache/ignite/pull/9018
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9018: IGNITE-14590 sort out the types/decimal and types/string directories
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9018:
URL: https://github.com/apache/ignite/pull/9018#discussion_r616530601
##########
File path: modules/calcite/src/test/java/org/apache/ignite/testsuites/ScriptTestSuite.java
##########
@@ -34,6 +34,6 @@
* Use other properties of the {@link ScriptRunnerTestsEnvironment} to setup cluster and test environment.
*/
@RunWith(ScriptTestRunner.class)
-@ScriptRunnerTestsEnvironment(scriptsRoot = "src/test/sql")
+@ScriptRunnerTestsEnvironment(scriptsRoot = "src/test/sql/types/")
Review comment:
Good catch! Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #9018: IGNITE-14590 sort out the types/decimal and types/string directories
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain commented on a change in pull request #9018:
URL: https://github.com/apache/ignite/pull/9018#discussion_r615701367
##########
File path: modules/calcite/src/test/sql/types/decimal/cast_from_decimal.test_ignored
##########
@@ -0,0 +1,78 @@
+# name: test/sql/types/decimal/cast_from_decimal.test
+# description: Test casting from decimal to numeric
+# group: [decimal]
Review comment:
What about link to jira issue for ignored tests (here and below)?
I guess we have to add at least one link at the header. If need some queries may be commented with separate issues too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #9018: IGNITE-14590 sort out the types/decimal and types/string directories
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #9018:
URL: https://github.com/apache/ignite/pull/9018#discussion_r616530957
##########
File path: modules/calcite/src/test/sql/types/decimal/cast_from_decimal.test_ignored
##########
@@ -0,0 +1,78 @@
+# name: test/sql/types/decimal/cast_from_decimal.test
+# description: Test casting from decimal to numeric
+# group: [decimal]
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on pull request #9018: IGNITE-14590 sort out the types/decimal and types/string directories
Posted by GitBox <gi...@apache.org>.
korlov42 commented on pull request #9018:
URL: https://github.com/apache/ignite/pull/9018#issuecomment-824850141
Merged outside GitHub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 closed pull request #9018: IGNITE-14590 sort out the types/decimal and types/string directories
Posted by GitBox <gi...@apache.org>.
korlov42 closed pull request #9018:
URL: https://github.com/apache/ignite/pull/9018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #9018: IGNITE-14590 sort out the types/decimal and types/string directories
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain commented on a change in pull request #9018:
URL: https://github.com/apache/ignite/pull/9018#discussion_r615698327
##########
File path: modules/calcite/src/test/java/org/apache/ignite/testsuites/ScriptTestSuite.java
##########
@@ -34,6 +34,6 @@
* Use other properties of the {@link ScriptRunnerTestsEnvironment} to setup cluster and test environment.
*/
@RunWith(ScriptTestRunner.class)
-@ScriptRunnerTestsEnvironment(scriptsRoot = "src/test/sql")
+@ScriptRunnerTestsEnvironment(scriptsRoot = "src/test/sql/types/")
Review comment:
Please revert debug changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org