You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/11 18:19:26 UTC

[GitHub] [streampipes] smlabt opened a new pull request, #1079: test: [#955] Add cypress test for api docs

smlabt opened a new pull request, #1079:
URL: https://github.com/apache/streampipes/pull/1079

   Closes #955 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [streampipes] tenthe merged pull request #1079: test: [#955] Add cypress test for api docs

Posted by GitBox <gi...@apache.org>.
tenthe merged PR #1079:
URL: https://github.com/apache/streampipes/pull/1079


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [streampipes] tenthe commented on pull request #1079: test: [#955] Add cypress test for api docs

Posted by GitBox <gi...@apache.org>.
tenthe commented on PR #1079:
URL: https://github.com/apache/streampipes/pull/1079#issuecomment-1379369500

   Hi @smlabt,
   thanks a lot for providing the test case. 
   Was it hard to setup cypress for the tests? Is there anything we can improve?
   
   I have one minor comment regarding the PR. Can you use add the `data-cy` property to the button (e.g.`data-cy=view-api-docs-btn`).
   If you use the data-cy property you can select the button with `cy.dataCy('view-api-docs-btn').click()`.
   With this change we have no dependency on the text of the button


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [streampipes] smlabt commented on pull request #1079: test: [#955] Add cypress test for api docs

Posted by GitBox <gi...@apache.org>.
smlabt commented on PR #1079:
URL: https://github.com/apache/streampipes/pull/1079#issuecomment-1379507011

   Hi @tenthe,
   
   for me it was pretty straightforward to set up and start the tests.
   I have added the `data-cy` property now :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org