You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/23 11:58:20 UTC
[GitHub] [incubator-nuttx] cisvanmierlo opened a new pull request, #6315: LCD / SSD1306 added (re)configure IOCTL
cisvanmierlo opened a new pull request, #6315:
URL: https://github.com/apache/incubator-nuttx/pull/6315
## Summary
Added IOCTL to (re)configure the display.
This is needed if for example the voltage domain of the display is not active during NuttX initialization.
## Impact
Extended current implementation with an extra IOCTL.
## Testing
Tested on a custom S32K1xx board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6315: LCD / SSD1306 added (re)configure IOCTL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6315:
URL: https://github.com/apache/incubator-nuttx/pull/6315#discussion_r880530846
##########
drivers/lcd/ssd1306_base.c:
##########
@@ -782,7 +783,7 @@ static int ssd1306_setpower(FAR struct lcd_dev_s *dev, int power)
{
/* Configure display and turn the display on */
- ret = ssd1306_configuredisplay(priv);
+ ret = ssd1306_configuredisplay(dev);
Review Comment:
If so, look like you have to turn on the display power before i2c transaction and turn off the display power after i2c. Of course, you need some form of reference counting, so the display power doesn't turn off prematurely if it's really used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6315: LCD / SSD1306 added (re)configure IOCTL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6315:
URL: https://github.com/apache/incubator-nuttx/pull/6315#discussion_r879772994
##########
drivers/lcd/ssd1306_base.c:
##########
@@ -782,7 +783,7 @@ static int ssd1306_setpower(FAR struct lcd_dev_s *dev, int power)
{
/* Configure display and turn the display on */
- ret = ssd1306_configuredisplay(priv);
+ ret = ssd1306_configuredisplay(dev);
Review Comment:
why the delay configuration here does work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6315: LCD / SSD1306 added (re)configure IOCTL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6315:
URL: https://github.com/apache/incubator-nuttx/pull/6315#discussion_r879772994
##########
drivers/lcd/ssd1306_base.c:
##########
@@ -782,7 +783,7 @@ static int ssd1306_setpower(FAR struct lcd_dev_s *dev, int power)
{
/* Configure display and turn the display on */
- ret = ssd1306_configuredisplay(priv);
+ ret = ssd1306_configuredisplay(dev);
Review Comment:
why the delay configuration here not work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cisvanmierlo commented on pull request #6315: LCD / SSD1306 added (re)configure IOCTL
Posted by GitBox <gi...@apache.org>.
cisvanmierlo commented on PR #6315:
URL: https://github.com/apache/incubator-nuttx/pull/6315#issuecomment-1135854878
Closed and replaced by PR #6319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cisvanmierlo commented on a diff in pull request #6315: LCD / SSD1306 added (re)configure IOCTL
Posted by GitBox <gi...@apache.org>.
cisvanmierlo commented on code in PR #6315:
URL: https://github.com/apache/incubator-nuttx/pull/6315#discussion_r880442001
##########
drivers/lcd/ssd1306_base.c:
##########
@@ -782,7 +783,7 @@ static int ssd1306_setpower(FAR struct lcd_dev_s *dev, int power)
{
/* Configure display and turn the display on */
- ret = ssd1306_configuredisplay(priv);
+ ret = ssd1306_configuredisplay(dev);
Review Comment:
Hi @xiaoxiang781216,
In our case, this SSD1306 display is pulling power from the I2C lines because the supply voltage of the display is not active yet.
This causes the I2C transactions to look OK, but in fact it is not being configured correctly.
I've checked, but there is no way to read out this display if it went OK.
We thought of a better solution and opened an other PR, see closing comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cisvanmierlo closed pull request #6315: LCD / SSD1306 added (re)configure IOCTL
Posted by GitBox <gi...@apache.org>.
cisvanmierlo closed pull request #6315: LCD / SSD1306 added (re)configure IOCTL
URL: https://github.com/apache/incubator-nuttx/pull/6315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org