You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/14 11:54:41 UTC

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5320: [BYOC] Prevent duplicate outputs in subgraph Tuple

mbaret commented on a change in pull request #5320: [BYOC] Prevent duplicate outputs in subgraph Tuple
URL: https://github.com/apache/incubator-tvm/pull/5320#discussion_r408077475
 
 

 ##########
 File path: tests/python/relay/test_annotated_regions.py
 ##########
 @@ -56,7 +56,7 @@ def test_region_set_creator_diamond():
         'test_target',
         [cb_1],
         [cb_1, O_1, ce_1, ce_2],
-        [ce_1, ce_2],
 
 Review comment:
   Apologies for the delayed response, we've been on holiday in the UK. I think C would be best as `AnnotatedRegionSet` probably shouldn't care about de-duplication logic - that's a specific requirement of `PartitionGraph`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services