[GitHub] mitchell852 commented on a change in pull request #1859: cr-config: calculating the hash-id if needed

[GitBox <gi...@apache.org>]

mitchell852 commented on a change in pull request #1859: cr-config: calculating the hash-id if needed
URL: https://github.com/apache/incubator-trafficcontrol/pull/1859#discussion_r167013045
 
 

 ##########
 File path: traffic_ops/app/lib/UI/Topology.pm
 ##########
 @@ -264,7 +264,7 @@ sub gen_crconfig_json {
             $data_obj->{'contentServers'}->{ $row->host_name }->{'ip6'}           = ( $row->ip6_address || "" );
             $data_obj->{'contentServers'}->{ $row->host_name }->{'profile'}       = $row->profile->name;
             $data_obj->{'contentServers'}->{ $row->host_name }->{'type'}          = $row->type->name;
-            $data_obj->{'contentServers'}->{ $row->host_name }->{'hashId'}        = $row->xmpp_id;
+            $data_obj->{'contentServers'}->{ $row->host_name }->{'hashId'}        = $row->xmpp_id ? $row->xmpp_id : $row->host_name;
 
 Review comment:
   would this allow an xmpp_id = "" which would probably not be a good thing. do we need a better test like isDefined and neq empty string?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services