[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25769: [SPARK-29032][CORE] Add PrometheusServlet to monitor Master/Worker/Driver

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #25769: [SPARK-29032][CORE] Add PrometheusServlet to monitor Master/Worker/Driver
URL: https://github.com/apache/spark/pull/25769#discussion_r331765457
 
 

 ##########
 File path: conf/metrics.properties.template
 ##########
 @@ -192,4 +201,10 @@
 
 #driver.source.jvm.class=org.apache.spark.metrics.source.JvmSource
 
-#executor.source.jvm.class=org.apache.spark.metrics.source.JvmSource
\ No newline at end of file
+#executor.source.jvm.class=org.apache.spark.metrics.source.JvmSource
+
+# Example configuration for PrometheusServlet
+#*.sink.prometheusServlet.class=org.apache.spark.metrics.sink.PrometheusServlet
+#*.sink.prometheusServlet.path=/metrics/prometheus
+#master.sink.prometheusServlet.path=/metrics/master/prometheus
+#applications.sink.prometheusServlet.path=/metrics/applications/prometheus
 
 Review comment:
   Actually, I've use this in a long-running spark streaming app in the dedicated Spark standalone cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org