You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 15:13:50 UTC

[GitHub] [arrow] pitrou opened a new pull request #12063: ARROW-15234: [Python] Fix crash with custom CSV invalid row handler

pitrou opened a new pull request #12063:
URL: https://github.com/apache/arrow/pull/12063


   The crash would happen at handler destruction if called from a non-Python thread that doesn't hold the GIL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12063: ARROW-15234: [Python] Fix crash with custom CSV invalid row handler

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12063:
URL: https://github.com/apache/arrow/pull/12063#issuecomment-1004225974


   Benchmark runs are scheduled for baseline = c6143a2396058dcc31506050238dc0f932aae9ba and contender = 47f6bc3976bcbabbd64c8bdf7f5e00cb0223f78d. 47f6bc3976bcbabbd64c8bdf7f5e00cb0223f78d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a4e1eed681e14aa1af1645c5c3df5a63...17b7569ed1a5455496f461db09e50000/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2d99c83643f04f1d846293758ffeb743...973b7355c4014a608cf8bdbc92491b96/)
   [Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f859be6e28b24204b6ba97625aaec35c...e37b343e59d848b4926b3731982c641c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm closed pull request #12063: ARROW-15234: [Python] Fix crash with custom CSV invalid row handler

Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12063:
URL: https://github.com/apache/arrow/pull/12063


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on pull request #12063: ARROW-15234: [Python] Fix crash with custom CSV invalid row handler

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12063:
URL: https://github.com/apache/arrow/pull/12063#issuecomment-1004223585


   Ah, I do see it failing elsewhere in CI. I think the existing tests are sufficient then and we should get in the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12063: ARROW-15234: [Python] Fix crash with custom CSV invalid row handler

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12063:
URL: https://github.com/apache/arrow/pull/12063#issuecomment-1004159523






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12063: ARROW-15234: [Python] Fix crash with custom CSV invalid row handler

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12063:
URL: https://github.com/apache/arrow/pull/12063#issuecomment-1004225974


   Benchmark runs are scheduled for baseline = c6143a2396058dcc31506050238dc0f932aae9ba and contender = 47f6bc3976bcbabbd64c8bdf7f5e00cb0223f78d. 47f6bc3976bcbabbd64c8bdf7f5e00cb0223f78d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a4e1eed681e14aa1af1645c5c3df5a63...17b7569ed1a5455496f461db09e50000/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2d99c83643f04f1d846293758ffeb743...973b7355c4014a608cf8bdbc92491b96/)
   [Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f859be6e28b24204b6ba97625aaec35c...e37b343e59d848b4926b3731982c641c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12063: ARROW-15234: [Python] Fix crash with custom CSV invalid row handler

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12063:
URL: https://github.com/apache/arrow/pull/12063#issuecomment-1004225974


   Benchmark runs are scheduled for baseline = c6143a2396058dcc31506050238dc0f932aae9ba and contender = 47f6bc3976bcbabbd64c8bdf7f5e00cb0223f78d. 47f6bc3976bcbabbd64c8bdf7f5e00cb0223f78d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a4e1eed681e14aa1af1645c5c3df5a63...17b7569ed1a5455496f461db09e50000/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2d99c83643f04f1d846293758ffeb743...973b7355c4014a608cf8bdbc92491b96/)
   [Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f859be6e28b24204b6ba97625aaec35c...e37b343e59d848b4926b3731982c641c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12063: ARROW-15234: [Python] Fix crash with custom CSV invalid row handler

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12063:
URL: https://github.com/apache/arrow/pull/12063#issuecomment-1004225974


   Benchmark runs are scheduled for baseline = c6143a2396058dcc31506050238dc0f932aae9ba and contender = 47f6bc3976bcbabbd64c8bdf7f5e00cb0223f78d. 47f6bc3976bcbabbd64c8bdf7f5e00cb0223f78d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a4e1eed681e14aa1af1645c5c3df5a63...17b7569ed1a5455496f461db09e50000/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2d99c83643f04f1d846293758ffeb743...973b7355c4014a608cf8bdbc92491b96/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f859be6e28b24204b6ba97625aaec35c...e37b343e59d848b4926b3731982c641c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org