You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/05 20:47:15 UTC

[GitHub] [commons-csv] garydgregory commented on pull request #114: CSV-264: Added DuplicateHeaderMode for flexibility with header strictness.

garydgregory commented on pull request #114:
URL: https://github.com/apache/commons-csv/pull/114#issuecomment-874321915


   @SethFalco 
   Please accept my apologieses for the delay in further reviewing this PR.
   
   I feel there is something important missing here:
   
   - What happens/should happen for each enum value when you call `CSVRecord.get(String)`.
   - What happens/should happen for each enum value when you call `CSVRecord.toMap()`.
   
   For example, if duplicate headers are allowed, does the first column win? Should it? Does the last column win? Certainly, it should not be random or undocumented.
   
   Also, would you mind rebasing on master please? I've recently deprecated the `with` methods in favor of a Builder. New settings should be added through the Builder, not `with` methods.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org