You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/28 09:23:58 UTC

[jira] [Commented] (FLINK-5171) Wrong use of Preconditions.checkState in TaskManagerRunner

    [ https://issues.apache.org/jira/browse/FLINK-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701426#comment-15701426 ] 

ASF GitHub Bot commented on FLINK-5171:
---------------------------------------

GitHub user shuai-xu opened a pull request:

    https://github.com/apache/flink/pull/2880

    [FLINK-5171] [runtime] fix wrong use of Preconditions.checkState in TaskManagerRunner

    This pr is for jira #[5171](https://issues.apache.org/jira/browse/FLINK-5171). 
    
    Preconditions.checkState will check the first parameter is true, if not, it will throw an exception. but in TaskManagerRunner, it will throw an exception if rpc port is valid.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shuai-xu/flink jira-5171

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2880.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2880
    
----
commit 0c223f91e56d1e11309affb0d92a95c82867b5a9
Author: shuai.xus <sh...@alibaba-inc.com>
Date:   2016-11-28T09:21:26Z

    [FLINK-5171] [runtime] fix wrong use of Preconditions.checkState in TaskManagerRunner

----


> Wrong use of Preconditions.checkState in TaskManagerRunner
> ----------------------------------------------------------
>
>                 Key: FLINK-5171
>                 URL: https://issues.apache.org/jira/browse/FLINK-5171
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>
> Preconditions.checkState will check the first parameter is true, if not, it will throw an exception. but in TaskManagerRunner, it will throw an exception if rpc port is valid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)