You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/17 21:26:33 UTC

[GitHub] [spark] redsk opened a new pull request #26153: [SPARK-29500][SQL][SS] Support partition column when writing to Kafka

redsk opened a new pull request #26153: [SPARK-29500][SQL][SS] Support partition column when writing to Kafka
URL: https://github.com/apache/spark/pull/26153
 
 
   ### What changes were proposed in this pull request?
   https://issues.apache.org/jira/browse/SPARK-29500
   
   `KafkaRowWriter` now supports setting the Kafka partition by reading a "partition" column in the input dataframe.
   
   Code changes in commit nr. 1.
   Test changes in commit nr. 2.
   Doc changes in commit nr. 3.
   
   @tcondie @dongjinleekr @srowen 
   
   ### Why are the changes needed?
   While it is possible to configure a custom Kafka Partitioner with
   `.option("kafka.partitioner.class", "my.custom.Partitioner")`, this is not enough for certain use cases. See the Jira issue.
   
   ### Does this PR introduce any user-facing change?
   No, as this behaviour is optional.
   
   ### How was this patch tested?
   Two new UT were added and one was updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org