You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Arpit Agarwal (JIRA)" <ji...@apache.org> on 2017/03/27 18:12:41 UTC
[jira] [Comment Edited] (HADOOP-14218) Replace assertThat with
assertTrue in MetricsAsserts
[ https://issues.apache.org/jira/browse/HADOOP-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943760#comment-15943760 ]
Arpit Agarwal edited comment on HADOOP-14218 at 3/27/17 6:12 PM:
-----------------------------------------------------------------
+1
was (Author: arpitagarwal):
+!
> Replace assertThat with assertTrue in MetricsAsserts
> ----------------------------------------------------
>
> Key: HADOOP-14218
> URL: https://issues.apache.org/jira/browse/HADOOP-14218
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Akira Ajisaka
> Assignee: Akira Ajisaka
> Priority: Minor
> Attachments: HADOOP-14218.01.patch
>
>
> {code:title=MetricsAsserts.java}
> public static void assertCounterGt(String name, long greater,
> MetricsRecordBuilder rb) {
> Assert.assertThat("Bad value for metric " + name, getLongCounter(name, rb),
> new GreaterThan<Long>(greater));
> }
> {code}
> The following code cannot be compiled with Mockito 2.1+ because it does not depend on org.hamcrest.Matcher anymore. We can simply replace this code with {{assertTrue(message, getLongCounter() > greater)}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org