You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Shraddha Pardeshi <sh...@freestoneinfotech.com> on 2021/08/10 06:09:57 UTC

Re: Review Request 73508: ATLAS-4233 [Atlas: Audits] When a term is added or removed, v1 api displays action as null instead of TERM_ADD or TERM_DELETE

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73508/
-----------------------------------------------------------

(Updated Aug. 10, 2021, 6:09 a.m.)


Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and Pinal Shah.


Bugs: ATLAS-4233
    https://issues.apache.org/jira/browse/ATLAS-4233


Repository: atlas


Description
-------

When we add or remove a term to an entity,in audits the action should appear as TERM_ADD or TERM_DELETE
But instead the value is giving null.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 5c08874ff 


Diff: https://reviews.apache.org/r/73508/diff/1/


Testing
-------

PC - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/792/console


Thanks,

Shraddha Pardeshi


Re: Review Request 73508: ATLAS-4233 [Atlas: Audits] When a term is added or removed, v1 api displays action as null instead of TERM_ADD or TERM_DELETE

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73508/#review223346
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 10, 2021, 6:09 a.m., Shraddha Pardeshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73508/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2021, 6:09 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and Pinal Shah.
> 
> 
> Bugs: ATLAS-4233
>     https://issues.apache.org/jira/browse/ATLAS-4233
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When we add or remove a term to an entity,in audits the action should appear as TERM_ADD or TERM_DELETE
> But instead the value is giving null.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 5c08874ff 
> 
> 
> Diff: https://reviews.apache.org/r/73508/diff/1/
> 
> 
> Testing
> -------
> 
> PC - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/792/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>


Re: Review Request 73508: ATLAS-4233 [Atlas: Audits] When a term is added or removed, v1 api displays action as null instead of TERM_ADD or TERM_DELETE

Posted by Nikhil Bonte <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73508/#review223345
-----------------------------------------------------------


Ship it!




Ship It!

- Nikhil Bonte


On Aug. 10, 2021, 11:39 a.m., Shraddha Pardeshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73508/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2021, 11:39 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and Pinal Shah.
> 
> 
> Bugs: ATLAS-4233
>     https://issues.apache.org/jira/browse/ATLAS-4233
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When we add or remove a term to an entity,in audits the action should appear as TERM_ADD or TERM_DELETE
> But instead the value is giving null.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 5c08874ff 
> 
> 
> Diff: https://reviews.apache.org/r/73508/diff/1/
> 
> 
> Testing
> -------
> 
> PC - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/792/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>