You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/15 20:06:00 UTC
[GitHub] [avro] radai-rosenblatt opened a new pull request #1550: AVRO-3382 (java) - require Schema argument be != null when creating a Schema.Field
radai-rosenblatt opened a new pull request #1550:
URL: https://github.com/apache/avro/pull/1550
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on a change in pull request #1550: AVRO-3382 (java) - require Schema argument be != null when creating a Schema.Field
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1550:
URL: https://github.com/apache/avro/pull/1550#discussion_r807298566
##########
File path: lang/java/avro/src/main/java/org/apache/avro/Schema.java
##########
@@ -1585,6 +1585,13 @@ private static String validateName(String name) {
return name;
}
+ private static <T> T requireNotNull(T input, String name) {
Review comment:
Maybe use `java.util.Objects#requireNonNull(T, java.lang.String)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] radai-rosenblatt commented on a change in pull request #1550: AVRO-3382 (java) - require Schema argument be != null when creating a Schema.Field
Posted by GitBox <gi...@apache.org>.
radai-rosenblatt commented on a change in pull request #1550:
URL: https://github.com/apache/avro/pull/1550#discussion_r807625624
##########
File path: lang/java/avro/src/main/java/org/apache/avro/Schema.java
##########
@@ -1585,6 +1585,13 @@ private static String validateName(String name) {
return name;
}
+ private static <T> T requireNotNull(T input, String name) {
Review comment:
this would throw an NPE and not an IllegalArgumentException. to most developers an NPE looks like a bug in the library rather than failed input validation.
but ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] radai-rosenblatt commented on pull request #1550: AVRO-3382 (java) - require Schema argument be != null when creating a Schema.Field
Posted by GitBox <gi...@apache.org>.
radai-rosenblatt commented on pull request #1550:
URL: https://github.com/apache/avro/pull/1550#issuecomment-1042969644
unit test added. I think this is ready for merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1550: AVRO-3382 (java) - require Schema argument be != null when creating a Schema.Field
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1550:
URL: https://github.com/apache/avro/pull/1550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org