You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/01/29 16:20:29 UTC

Review Request 30416: ambari db upgrade 1.6.1 -> 2.0.0 fails

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30416/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.


Bugs: AMBARI-9400
    https://issues.apache.org/jira/browse/AMBARI-9400


Repository: ambari


Description
-------

Upgrade command fails:
{code}
ambari-server upgrade
Using python  /usr/bin/python2.6
Upgrading ambari-server
Updating properties in ambari.properties ...
WARNING: server.jdbc.database_name property isn't set in ambari.properties. Setting it to default value - ambari
Fixing database objects owner
ERROR: Exiting with exit code 15.
REASON: Invalid database selection: local
{code}


Diffs
-----

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 3f04840 
  ambari-server/src/test/python/TestAmbariServer.py caa1cf5 

Diff: https://reviews.apache.org/r/30416/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 30416: ambari db upgrade 1.6.1 -> 2.0.0 fails

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30416/#review70208
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Jan. 29, 2015, 3:20 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30416/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 3:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9400
>     https://issues.apache.org/jira/browse/AMBARI-9400
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Upgrade command fails:
> {code}
> ambari-server upgrade
> Using python  /usr/bin/python2.6
> Upgrading ambari-server
> Updating properties in ambari.properties ...
> WARNING: server.jdbc.database_name property isn't set in ambari.properties. Setting it to default value - ambari
> Fixing database objects owner
> ERROR: Exiting with exit code 15.
> REASON: Invalid database selection: local
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 3f04840 
>   ambari-server/src/test/python/TestAmbariServer.py caa1cf5 
> 
> Diff: https://reviews.apache.org/r/30416/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 30416: ambari db upgrade 1.6.1 -> 2.0.0 fails

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30416/#review70385
-----------------------------------------------------------

Ship it!



ambari-server/src/main/python/ambari_server/serverConfiguration.py
<https://reviews.apache.org/r/30416/#comment115531>

    JDBC_RCA_SCHEMA_PROPERTY is not actually used anywhere.
    
    In Ambari 1.6.1, a local database using Postgres had the DB name inside JDBC_DATABASE_PROPERTY property. So hopefully no user had their database name as postgres, orcale, mysql, or derby.
    
    This will work.


- Alejandro Fernandez


On Jan. 29, 2015, 3:20 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30416/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 3:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9400
>     https://issues.apache.org/jira/browse/AMBARI-9400
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Upgrade command fails:
> {code}
> ambari-server upgrade
> Using python  /usr/bin/python2.6
> Upgrading ambari-server
> Updating properties in ambari.properties ...
> WARNING: server.jdbc.database_name property isn't set in ambari.properties. Setting it to default value - ambari
> Fixing database objects owner
> ERROR: Exiting with exit code 15.
> REASON: Invalid database selection: local
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 3f04840 
>   ambari-server/src/test/python/TestAmbariServer.py caa1cf5 
> 
> Diff: https://reviews.apache.org/r/30416/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>