You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/09/02 20:00:54 UTC
Review Request 68604: Wrapped syscall initgroups by warning
suppression pragma.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68604/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Gilbert Song.
Bugs: MESOS-8457
https://issues.apache.org/jira/browse/MESOS-8457
Repository: mesos
Description
-------
Wrapped syscall initgroups by warning suppression pragma.
Diffs
-----
3rdparty/stout/include/stout/os/posix/su.hpp 715f88852012b0efbc5dff38307a23175b2ff95f
Diff: https://reviews.apache.org/r/68604/diff/1/
Testing
-------
Built on macOS 10.14 using Apple LLVM version 10.0.0 (clang-1000.10.43.1)
Thanks,
Till Toenshoff
Re: Review Request 68604: Wrapped syscall initgroups by warning
suppression pragma.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
> On Sept. 2, 2018, 8:20 p.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/os/posix/su.hpp
> > Lines 264-266 (original), 270-273 (patched)
> > <https://reviews.apache.org/r/68604/diff/1/?file=2080298#file2080298line270>
> >
> > If I remove this block completely, not stout tests would fail on macos-10.13.6. Could you create a tech debt ticket to add a test (maybe for stout's `setgroups` in general)?
https://issues.apache.org/jira/browse/MESOS-9202
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68604/#review208240
-----------------------------------------------------------
On Sept. 2, 2018, 8 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68604/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2018, 8 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gilbert Song.
>
>
> Bugs: MESOS-8457
> https://issues.apache.org/jira/browse/MESOS-8457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Wrapped syscall initgroups by warning suppression pragma.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/su.hpp 715f88852012b0efbc5dff38307a23175b2ff95f
>
>
> Diff: https://reviews.apache.org/r/68604/diff/1/
>
>
> Testing
> -------
>
> Built on macOS 10.14 using Apple LLVM version 10.0.0 (clang-1000.10.43.1)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 68604: Wrapped syscall initgroups by warning
suppression pragma.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68604/#review208240
-----------------------------------------------------------
Fix it, then Ship it!
LGTM! Thanks for fixing this Till. This was a very noisy warning.
3rdparty/stout/include/stout/os/posix/su.hpp
Lines 264-266 (original), 270-273 (patched)
<https://reviews.apache.org/r/68604/#comment291967>
If I remove this block completely, not stout tests would fail on macos-10.13.6. Could you create a tech debt ticket to add a test (maybe for stout's `setgroups` in general)?
- Benjamin Bannier
On Sept. 2, 2018, 10 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68604/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2018, 10 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gilbert Song.
>
>
> Bugs: MESOS-8457
> https://issues.apache.org/jira/browse/MESOS-8457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Wrapped syscall initgroups by warning suppression pragma.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/su.hpp 715f88852012b0efbc5dff38307a23175b2ff95f
>
>
> Diff: https://reviews.apache.org/r/68604/diff/1/
>
>
> Testing
> -------
>
> Built on macOS 10.14 using Apple LLVM version 10.0.0 (clang-1000.10.43.1)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 68604: Wrapped syscall initgroups by warning
suppression pragma.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68604/#review208242
-----------------------------------------------------------
PASS: Mesos patch 68604 was successfully built and tested.
Reviews applied: `['68604']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2277/mesos-review-68604
- Mesos Reviewbot Windows
On Sept. 2, 2018, 8 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68604/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2018, 8 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gilbert Song.
>
>
> Bugs: MESOS-8457
> https://issues.apache.org/jira/browse/MESOS-8457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Wrapped syscall initgroups by warning suppression pragma.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/su.hpp 715f88852012b0efbc5dff38307a23175b2ff95f
>
>
> Diff: https://reviews.apache.org/r/68604/diff/1/
>
>
> Testing
> -------
>
> Built on macOS 10.14 using Apple LLVM version 10.0.0 (clang-1000.10.43.1)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 68604: Wrapped syscall initgroups by warning
suppression pragma.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68604/#review208243
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68604]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 2, 2018, 1 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68604/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2018, 1 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gilbert Song.
>
>
> Bugs: MESOS-8457
> https://issues.apache.org/jira/browse/MESOS-8457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Wrapped syscall initgroups by warning suppression pragma.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/su.hpp 715f88852012b0efbc5dff38307a23175b2ff95f
>
>
> Diff: https://reviews.apache.org/r/68604/diff/1/
>
>
> Testing
> -------
>
> Built on macOS 10.14 using Apple LLVM version 10.0.0 (clang-1000.10.43.1)
>
>
> Thanks,
>
> Till Toenshoff
>
>