[GitHub] [beam] y1chi commented on a diff in pull request #17818: [BEAM-14553] Add destination coder to FileResultCoder components

[GitBox <gi...@apache.org>]

y1chi commented on code in PR #17818:
URL: https://github.com/apache/beam/pull/17818#discussion_r888423143


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java:
##########
@@ -1196,7 +1196,7 @@ public static <DestinationT> FileResultCoder<DestinationT> of(
 
     @Override
     public List<? extends Coder<?>> getCoderArguments() {
-      return Arrays.asList(windowCoder);
+      return Arrays.asList(windowCoder, destinationCoder);

Review Comment:
   Should it be FileResult<BoundedWindowT, DestinationT> and the windowCoder being Coder<BoundedWindowT extends BoundedWindow>? Looking from the code it think the window coder can change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org