You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@graphar.apache.org by "shivendra-dev54 (via GitHub)" <gi...@apache.org> on 2026/01/09 15:06:09 UTC
[PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
shivendra-dev54 opened a new pull request, #824:
URL: https://github.com/apache/incubator-graphar/pull/824
Fixes #757
### Reason for this PR
Spark and Java tests currently rely on the `GAR_TEST_DATA` environment variable.
This PR adds fallback logic to locate the `testing` directory from the project
root or its parent when the environment variable is not set, avoiding test
failures in local environments.
### What changes are included in this PR?
The following test files were updated to add fallback test-data resolution logic:
1. `maven-projects/java/src/test/java/org/apache/graphar/graphinfo/GraphInfoTest.java`
2. `maven-projects/spark/graphar/src/test/scala/org/apache/graphar/BaseTestSuite.scala`
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#discussion_r2679427106
##########
maven-projects/spark/graphar/src/test/scala/org/apache/graphar/BaseTestSuite.scala:
##########
@@ -29,10 +29,25 @@ abstract class BaseTestSuite extends AnyFunSuite with BeforeAndAfterAll {
var spark: SparkSession = _
override def beforeAll(): Unit = {
- if (System.getenv("GAR_TEST_DATA") == null) {
- throw new IllegalArgumentException("GAR_TEST_DATA is not set")
+ def resolveTestData(): String = {
+ Option(System.getenv("GAR_TEST_DATA"))
+ .orElse(Option(System.getProperty("gar.test.data")))
+ .getOrElse {
+ val candidates = Seq("../../testing", "../testing", "testing")
+ candidates
+ .map(p => new java.io.File(p).getAbsoluteFile)
+ .find(d =>
+ new java.io.File(d, "ldbc_sample/csv/ldbc_sample.graph.yml")
+ .exists()
+ )
+ .map(_.getAbsolutePath)
+ .getOrElse(
+ throw new IllegalArgumentException("GAR_TEST_DATA not found")
Review Comment:
The exception type differs from the one used in TestUtil.java, which uses RuntimeException. Consider using RuntimeException instead of IllegalArgumentException for consistency across the codebase, or document why a different exception type is appropriate here.
```suggestion
throw new RuntimeException("GAR_TEST_DATA not found")
```
##########
maven-projects/spark/graphar/src/test/scala/org/apache/graphar/BaseTestSuite.scala:
##########
@@ -29,10 +29,25 @@ abstract class BaseTestSuite extends AnyFunSuite with BeforeAndAfterAll {
var spark: SparkSession = _
override def beforeAll(): Unit = {
- if (System.getenv("GAR_TEST_DATA") == null) {
- throw new IllegalArgumentException("GAR_TEST_DATA is not set")
+ def resolveTestData(): String = {
+ Option(System.getenv("GAR_TEST_DATA"))
+ .orElse(Option(System.getProperty("gar.test.data")))
+ .getOrElse {
+ val candidates = Seq("../../testing", "../testing", "testing")
+ candidates
+ .map(p => new java.io.File(p).getAbsoluteFile)
+ .find(d =>
+ new java.io.File(d, "ldbc_sample/csv/ldbc_sample.graph.yml")
+ .exists()
+ )
+ .map(_.getAbsolutePath)
+ .getOrElse(
+ throw new IllegalArgumentException("GAR_TEST_DATA not found")
Review Comment:
The error message is less informative than the one used in TestUtil.java. TestUtil.java provides a more detailed message that explains both the environment variable option and the directory structure requirement. Consider updating the message to match the clarity of TestUtil.java's error message which states: "GAR_TEST_DATA not found or invalid. Please set GAR_TEST_DATA environment variable to point to the testing directory or ensure the testing directory exists with ldbc_sample/csv/ldbc_sample.graph.yml".
```suggestion
throw new IllegalArgumentException(
"GAR_TEST_DATA not found or invalid. Please set GAR_TEST_DATA environment variable to point to the testing directory or ensure the testing directory exists with ldbc_sample/csv/ldbc_sample.graph.yml"
)
```
##########
maven-projects/java/src/test/java/org/apache/graphar/graphinfo/GraphInfoTest.java:
##########
@@ -32,7 +32,25 @@
import org.junit.Test;
public class GraphInfoTest {
- public static final String root = System.getenv("GAR_TEST_DATA") + "/java";
+ private static String resolveTestData() {
+ String path = System.getenv("GAR_TEST_DATA");
+ if (path == null) {
+ path = System.getProperty("gar.test.data");
+ }
+ if (path == null) {
+ String[] candidates = {"../../testing", "../testing", "testing"};
+ for (String p : candidates) {
+ java.io.File dir = new java.io.File(p).getAbsoluteFile();
+ if (new java.io.File(dir, "ldbc_sample/csv/ldbc_sample.graph.yml").exists()) {
+ return dir.getAbsolutePath();
+ }
+ }
+ throw new IllegalStateException("GAR_TEST_DATA not found");
+ }
+ return path;
Review Comment:
The validation approach differs from TestUtil.java which performs additional verification after finding a path. TestUtil.java re-validates the chosen path to ensure both the directory and the marker file exist. This double-checking approach is more robust and catches edge cases. Consider adding a final validation step after selecting a path to ensure it's valid before returning it.
```suggestion
path = dir.getAbsolutePath();
break;
}
}
if (path == null) {
throw new IllegalStateException("GAR_TEST_DATA not found");
}
}
java.io.File baseDir = new java.io.File(path).getAbsoluteFile();
java.io.File markerFile =
new java.io.File(baseDir, "ldbc_sample/csv/ldbc_sample.graph.yml");
if (!baseDir.isDirectory() || !markerFile.exists()) {
throw new IllegalStateException("GAR_TEST_DATA not found");
}
return baseDir.getAbsolutePath();
```
##########
maven-projects/java/src/test/java/org/apache/graphar/graphinfo/GraphInfoTest.java:
##########
@@ -32,7 +32,25 @@
import org.junit.Test;
public class GraphInfoTest {
- public static final String root = System.getenv("GAR_TEST_DATA") + "/java";
+ private static String resolveTestData() {
+ String path = System.getenv("GAR_TEST_DATA");
+ if (path == null) {
+ path = System.getProperty("gar.test.data");
+ }
+ if (path == null) {
+ String[] candidates = {"../../testing", "../testing", "testing"};
+ for (String p : candidates) {
+ java.io.File dir = new java.io.File(p).getAbsoluteFile();
+ if (new java.io.File(dir, "ldbc_sample/csv/ldbc_sample.graph.yml").exists()) {
+ return dir.getAbsolutePath();
+ }
+ }
+ throw new IllegalStateException("GAR_TEST_DATA not found");
Review Comment:
The exception type differs from the one used in TestUtil.java, which uses RuntimeException. Consider using RuntimeException instead of IllegalStateException for consistency across the codebase, or document why a different exception type is appropriate here.
```suggestion
throw new RuntimeException("GAR_TEST_DATA not found");
```
##########
maven-projects/spark/graphar/src/test/scala/org/apache/graphar/BaseTestSuite.scala:
##########
@@ -29,10 +29,25 @@ abstract class BaseTestSuite extends AnyFunSuite with BeforeAndAfterAll {
var spark: SparkSession = _
override def beforeAll(): Unit = {
- if (System.getenv("GAR_TEST_DATA") == null) {
- throw new IllegalArgumentException("GAR_TEST_DATA is not set")
+ def resolveTestData(): String = {
+ Option(System.getenv("GAR_TEST_DATA"))
+ .orElse(Option(System.getProperty("gar.test.data")))
+ .getOrElse {
+ val candidates = Seq("../../testing", "../testing", "testing")
+ candidates
+ .map(p => new java.io.File(p).getAbsoluteFile)
+ .find(d =>
+ new java.io.File(d, "ldbc_sample/csv/ldbc_sample.graph.yml")
+ .exists()
+ )
+ .map(_.getAbsolutePath)
+ .getOrElse(
+ throw new IllegalArgumentException("GAR_TEST_DATA not found")
+ )
+ }
}
- testData = System.getenv("GAR_TEST_DATA")
+
+ testData = resolveTestData()
Review Comment:
The validation approach differs from TestUtil.java which performs additional verification after finding a path. TestUtil.java re-validates the chosen path to ensure both the directory and the marker file exist. This double-checking approach is more robust and catches edge cases. Consider adding a final validation step after selecting a path to ensure it's valid before returning it.
##########
maven-projects/spark/graphar/src/test/scala/org/apache/graphar/BaseTestSuite.scala:
##########
@@ -29,10 +29,25 @@ abstract class BaseTestSuite extends AnyFunSuite with BeforeAndAfterAll {
var spark: SparkSession = _
override def beforeAll(): Unit = {
- if (System.getenv("GAR_TEST_DATA") == null) {
- throw new IllegalArgumentException("GAR_TEST_DATA is not set")
+ def resolveTestData(): String = {
+ Option(System.getenv("GAR_TEST_DATA"))
+ .orElse(Option(System.getProperty("gar.test.data")))
+ .getOrElse {
+ val candidates = Seq("../../testing", "../testing", "testing")
+ candidates
+ .map(p => new java.io.File(p).getAbsoluteFile)
+ .find(d =>
+ new java.io.File(d, "ldbc_sample/csv/ldbc_sample.graph.yml")
+ .exists()
Review Comment:
The validation logic is inconsistent with the existing implementation in TestUtil.java. The Scala code only checks if the file exists, but TestUtil.java also verifies that the directory exists and is actually a directory. This could lead to false positives if the parent path doesn't exist. Consider adding an additional check to verify that the parent directory exists and is a directory before checking for the specific file.
```suggestion
d.exists() && d.isDirectory &&
new java.io.File(d, "ldbc_sample/csv/ldbc_sample.graph.yml")
.isFile
```
##########
maven-projects/java/src/test/java/org/apache/graphar/graphinfo/GraphInfoTest.java:
##########
@@ -32,7 +32,25 @@
import org.junit.Test;
public class GraphInfoTest {
- public static final String root = System.getenv("GAR_TEST_DATA") + "/java";
+ private static String resolveTestData() {
+ String path = System.getenv("GAR_TEST_DATA");
+ if (path == null) {
+ path = System.getProperty("gar.test.data");
+ }
+ if (path == null) {
+ String[] candidates = {"../../testing", "../testing", "testing"};
+ for (String p : candidates) {
+ java.io.File dir = new java.io.File(p).getAbsoluteFile();
+ if (new java.io.File(dir, "ldbc_sample/csv/ldbc_sample.graph.yml").exists()) {
+ return dir.getAbsolutePath();
Review Comment:
The validation logic is inconsistent with the existing implementation in TestUtil.java. The current code only checks if the file exists, but TestUtil.java also verifies that the directory exists and is actually a directory. This could lead to false positives if the parent path doesn't exist. Consider adding an additional check to verify that the parent directory exists and is a directory before checking for the specific file.
```suggestion
if (dir.exists() && dir.isDirectory()) {
java.io.File graphFile =
new java.io.File(dir, "ldbc_sample/csv/ldbc_sample.graph.yml");
if (graphFile.exists()) {
return dir.getAbsolutePath();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on code in PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#discussion_r2680704924
##########
maven-projects/spark/graphar/src/test/scala/org/apache/graphar/BaseTestSuite.scala:
##########
@@ -29,10 +29,25 @@ abstract class BaseTestSuite extends AnyFunSuite with BeforeAndAfterAll {
var spark: SparkSession = _
override def beforeAll(): Unit = {
- if (System.getenv("GAR_TEST_DATA") == null) {
- throw new IllegalArgumentException("GAR_TEST_DATA is not set")
+ def resolveTestData(): String = {
+ Option(System.getenv("GAR_TEST_DATA"))
+ .orElse(Option(System.getProperty("gar.test.data")))
+ .getOrElse {
+ val candidates = Seq("../../testing", "../testing", "testing")
+ candidates
+ .map(p => new java.io.File(p).getAbsoluteFile)
+ .find(d =>
+ new java.io.File(d, "ldbc_sample/csv/ldbc_sample.graph.yml")
+ .exists()
+ )
+ .map(_.getAbsolutePath)
+ .getOrElse(
+ throw new IllegalArgumentException("GAR_TEST_DATA not found")
+ )
+ }
}
- testData = System.getenv("GAR_TEST_DATA")
+
+ testData = resolveTestData()
Review Comment:
@shivendra-dev54 Please consider this comment, it looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3734378903
Let me see why this is happening, please wait a moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3734357929
Hi @shivendra-dev54, python sdk is built using pybind11 and depends on c++ library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "shivendra-dev54 (via GitHub)" <gi...@apache.org>.
shivendra-dev54 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3737121486
@yangxk1
I have updated the code with the changes you suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "shivendra-dev54 (via GitHub)" <gi...@apache.org>.
shivendra-dev54 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3729377279
@yangxk1
@Thespica
i have added the logic mentioned in the issue #757
Also why is python pipeline failing ???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 merged PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "shivendra-dev54 (via GitHub)" <gi...@apache.org>.
shivendra-dev54 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3734374447
Thanks for the clarification.
Just to confirm do the current changes meet the requirements, or is anything else needed from my side?
I added the logic where it was not present, Am i missing something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on code in PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#discussion_r2680702167
##########
maven-projects/spark/graphar/src/test/scala/org/apache/graphar/BaseTestSuite.scala:
##########
@@ -29,10 +29,25 @@ abstract class BaseTestSuite extends AnyFunSuite with BeforeAndAfterAll {
var spark: SparkSession = _
override def beforeAll(): Unit = {
- if (System.getenv("GAR_TEST_DATA") == null) {
- throw new IllegalArgumentException("GAR_TEST_DATA is not set")
+ def resolveTestData(): String = {
+ Option(System.getenv("GAR_TEST_DATA"))
+ .orElse(Option(System.getProperty("gar.test.data")))
+ .getOrElse {
+ val candidates = Seq("../../testing", "../testing", "testing")
+ candidates
+ .map(p => new java.io.File(p).getAbsoluteFile)
+ .find(d =>
+ new java.io.File(d, "ldbc_sample/csv/ldbc_sample.graph.yml")
+ .exists()
+ )
+ .map(_.getAbsolutePath)
+ .getOrElse(
+ throw new IllegalArgumentException("GAR_TEST_DATA not found")
Review Comment:
@shivendra-dev54, You can consider adopting this suggestion, it makes the error message clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3737145477
Oh!!! I forgot to check the PR name, please remember to remind me next time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3737159934
here https://github.com/apache/incubator-graphar/blob/main/CONTRIBUTING.md#title, This will make it easier to classify PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3729316864
## [Codecov](https://app.codecov.io/gh/apache/incubator-graphar/pull/824?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 77.17%. Comparing base ([`23c46c2`](https://app.codecov.io/gh/apache/incubator-graphar/commit/23c46c2090bc59e20334d527ffaadb3f7380425e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`612adf3`](https://app.codecov.io/gh/apache/incubator-graphar/commit/612adf33cd38b67e8ca1ccfd440116f56c0addc3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #824 +/- ##
============================================
- Coverage 77.18% 77.17% -0.02%
Complexity 607 607
============================================
Files 85 84 -1
Lines 8858 8854 -4
Branches 1043 1043
============================================
- Hits 6837 6833 -4
Misses 1781 1781
Partials 240 240
```
| [Flag](https://app.codecov.io/gh/apache/incubator-graphar/pull/824/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [spark](https://app.codecov.io/gh/apache/incubator-graphar/pull/824/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.32% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-graphar/pull/824?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3734457213
@shivendra-dev54 This problem seems to be solved. In addition.
And I am sorry that my conclusion just now was incorrect. The problem that just appeared is the pyspark module not python module. It depends on the spark module, so changes to spark will affect pyspark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "shivendra-dev54 (via GitHub)" <gi...@apache.org>.
shivendra-dev54 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3734783151
@yangxk1
ohk thank you for the help ✨
is there anything else you want me to do in this or this logic is enough,
Like does this solve the issue #757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3737139096
Great! In the `java/` module, a better approach is to create a public method, although it will only be used in one place. But this is not the key issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] added logic for finding test data in root and parent dir of project f… [incubator-graphar]
Posted by "shivendra-dev54 (via GitHub)" <gi...@apache.org>.
shivendra-dev54 commented on PR #824:
URL: https://github.com/apache/incubator-graphar/pull/824#issuecomment-3737151234
@yangxk1
I will,
is there any format you can share me ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org