You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/17 21:15:41 UTC
[jira] [Commented] (GEODE-2686) Remove JarClassLoader

    [ https://issues.apache.org/jira/browse/GEODE-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930744#comment-15930744 ] 

ASF GitHub Bot commented on GEODE-2686:
---------------------------------------

GitHub user jaredjstewart opened a pull request:

    https://github.com/apache/geode/pull/429

    Geode-2686

    GEODE-2686: Remove JarClassLoader  …
     - Remove JarClassLoader
     - Replace ClassPathLoader's collection of JarClassLoaders with a single URLClassLoader
     - Change naming scheme for deployed jars from 'vf.gf#myJar.jar#1' to 'myJar.v1.jar'
    
    Change singleton implementation of ClassPathLoader from AtomicReference to volatile
    
    JarDeployer is threadsafe

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaredjstewart/geode GEODE-2686

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #429
    
----
commit 7788dba702a58e2c3997b974badd8e45e861b47f
Author: Jared Stewart <js...@pivotal.io>
Date:   2017-01-19T20:00:04Z

    GEODE-2686: Remove JarClassLoader
    
     - Remove JarClassLoader
     - Replace ClassPathLoader's collection of JarClassLoaders with a single URLClassLoader
     - Change naming scheme for deployed jars from 'vf.gf#myJar.jar#1' to 'myJar.v1.jar'

commit b9e511262b853e6f7ae346eb414138813c0e7a2d
Author: Jared Stewart <js...@pivotal.io>
Date:   2017-03-17T00:22:59Z

    Change singleton implementation of ClassPathLoader from AtomicReference to volatile

commit 5d50b12cc389293246545f08608663df9f962419
Author: Jared Stewart <js...@pivotal.io>
Date:   2017-03-17T20:59:32Z

    JarDeployer is threadsafe

----


> Remove JarClassLoader
> ---------------------
>
>                 Key: GEODE-2686
>                 URL: https://issues.apache.org/jira/browse/GEODE-2686
>             Project: Geode
>          Issue Type: Sub-task
>          Components: management
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> Before we can limit the scanning of deployed jars, we need to extricate JarClassLoader, as its implementation eagerly loads all classes into memory.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)