[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7199: GEODE-9770: Retry creating region when cache is closed

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #7199:
URL: https://github.com/apache/geode/pull/7199#discussion_r769871551



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/persistence/PersistentRecoveryOrderDUnitTest.java
##########
@@ -1326,6 +1326,10 @@ public void testRecoverAfterConflict() {
     vm1.invoke(() -> getCache().close());
 
     vm0.invoke(() -> {
+      await().untilAsserted(

Review comment:
       It might be better to just change this test to test the more normal use case of restarting the member that had the ConflictingPersistentDataException. I think you could do that in this test by closing the cache in vm0 when you catch ConflictingPersistentDataException. Then the test would close vm1 and then when vm0 calls createReplicationRegion it will be with a new cache. I don't think we need to test that a member that saw this exception can later on create the region using the same cache.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org