You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2018/02/01 10:07:37 UTC
[isis] 02/02: ISIS-1569: improves log message and javadoc in
BackgroundCommandExecution, is all.
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch maint-1.16.1
in repository https://gitbox.apache.org/repos/asf/isis.git
commit a4fc90bfdd21ce079a9acdea731a0a4c12e15b74
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Thu Feb 1 09:05:18 2018 +0000
ISIS-1569: improves log message and javadoc in BackgroundCommandExecution, is all.
---
.../background/BackgroundCommandExecution.java | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java b/core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
index 7f616aa..9127933 100644
--- a/core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
+++ b/core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
@@ -146,8 +146,7 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
final boolean shouldContinue = execute(transactionManager, command);
if(!shouldContinue) {
- LOG.info("OnExceptionPolicy is to QUIT, so skipping further processing",
- command.getMemberIdentifier());
+ LOG.info("NOT continuing to process any further commands, quitting execution");
return;
}
}
@@ -160,7 +159,9 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
// //////////////////////////////////////
-
+ /**
+ * @return - whether to process any further commands.
+ */
private boolean execute(
final IsisTransactionManager transactionManager,
final Command command) {
@@ -202,6 +203,9 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
}
}
+ /**
+ * @return - whether to process any further commands.
+ */
private Boolean executeCommandWithinTran(
final IsisTransactionManager transactionManager,
final Command command) {
@@ -217,6 +221,9 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
});
}
+ /**
+ * @return - whether to process any further commands.
+ */
private Boolean executeCommandPerSudoPolicy(
final IsisTransactionManager transactionManager,
final Command command) {
@@ -241,6 +248,8 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
* Simply delegates to {@link #doExecuteCommand(IsisTransactionManager, Command)}.
*
* Overridable, so execution policy can be adjusted if required.
+ *
+ * @return - whether to process any further commands.
*/
protected Boolean executeCommand(
final IsisTransactionManager transactionManager,
@@ -250,6 +259,8 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
/**
* Not overrideable, but intended to be called by {@link #executeCommand(IsisTransactionManager, Command)} (which is).
+ *
+ * @return - whether to process any further commands.
*/
protected final Boolean doExecuteCommand(
final IsisTransactionManager transactionManager,
@@ -567,5 +578,4 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
@javax.inject.Inject
ClockService clockService;
-
}
--
To stop receiving notification emails like this one, please contact
danhaywood@apache.org.