You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/02 18:01:11 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #1340: Return "name" field as VM name in Azure environment
zhangmeng916 opened a new pull request #1340:
URL: https://github.com/apache/helix/pull/1340
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fix #1339
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
When Helix uses auto registration feature to get VM metadata information from Azure, the name of that VM is in "name" field rather than "vmId" field. "vmId" is more like a serial number, and won't provide much information for users. Details in this page: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/instance-metadata-service
This PR fixed this issue and also some other minor typos
### Tests
- [X] The following is the result of the "mvn test" command on the appropriate module:
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on a change in pull request #1340: Return "name" field as VM name in Azure environment
Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #1340:
URL: https://github.com/apache/helix/pull/1340#discussion_r482273331
##########
File path: helix-core/src/main/java/org/apache/helix/cloud/azure/AzureCloudInstanceInformationProcessor.java
##########
@@ -49,14 +49,14 @@
private final CloseableHttpClient _closeableHttpClient;
private final HelixCloudProperty _helixCloudProperty;
private final String COMPUTE = "compute";
- private final String INSTANCE_NAME = "vmId";
+ private final String INSTANCE_NAME = "name";
Review comment:
If they are constants, they should be `static final`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1340: Return "name" field as VM name in Azure environment
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1340:
URL: https://github.com/apache/helix/pull/1340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #1340: Return "name" field as VM name in Azure environment
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1340:
URL: https://github.com/apache/helix/pull/1340#issuecomment-686273407
This PR is ready to be merged, approved by @pkuwm
Final commit message:
Return "name" field as VM name in Azure cloud environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org