You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by keith-turner <gi...@git.apache.org> on 2016/11/17 18:54:29 UTC
[GitHub] incubator-fluo pull request #804: Added some caching of string to bytes conv...
GitHub user keith-turner opened a pull request:
https://github.com/apache/incubator-fluo/pull/804
Added some caching of string to bytes conversions for #800
* Added some localized per transactions caching of string to bytes conversions
* Optimized hashCode(), equals(), and compareTo() methods for data objects in API
* Made transaction reuse passed in Bytes and Column objects when returning data
* Optimized Bytes.toString() by weakly remembering the string that created it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith-turner/fluo fluo-800
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fluo/pull/804.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #804
----
commit c5efed75775d6cea6680e93b02dfef534301c5cc
Author: Keith Turner <kt...@apache.org>
Date: 2016-11-17T00:32:22Z
Added some caching of string to bytes conversions for #800
* Added some localized per transactions caching of string to bytes conversions
* Optimized hashCode(), equals(), and compareTo() methods for data objects in API
* Made transaction reuse passed in Bytes and Column objects when returning data
* Optimized Bytes.toString() by weakly remembering the string that created it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo pull request #804: Added some caching of string to bytes conv...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo/pull/804#discussion_r88529159
--- Diff: modules/core/src/main/java/org/apache/fluo/core/util/ColumnUtil.java ---
@@ -115,4 +115,12 @@ public static Column readColumn(DataInputStream in) throws IOException {
Bytes visibility = ByteUtil.read(bb, in);
return new Column(family, qualifier, visibility);
}
+
+ // TODO move
--- End diff --
I did move it, I just forgot to remove the TODO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo pull request #804: Added some caching of string to bytes conv...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-fluo/pull/804
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo pull request #804: Added some caching of string to bytes conv...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo/pull/804#discussion_r88521218
--- Diff: modules/core/src/main/java/org/apache/fluo/core/util/ColumnUtil.java ---
@@ -115,4 +115,12 @@ public static Column readColumn(DataInputStream in) throws IOException {
Bytes visibility = ByteUtil.read(bb, in);
return new Column(family, qualifier, visibility);
}
+
+ // TODO move
--- End diff --
Could create an issue rather than leave a TODO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---