You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/03 19:28:26 UTC
[GitHub] [flink] ayushtkn opened a new pull request #11005: [FLINK-15838]
Dangling CountDownLatch.await(timeout)
ayushtkn opened a new pull request #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11005: [FLINK-15838]
Dangling CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581588915
<!--
Meta data
Hash:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147267156 TriggerType:PUSH TriggerID:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509
Hash:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4800 TriggerType:PUSH TriggerID:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509
-->
## CI report:
* ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147267156) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4800)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] ayushtkn commented on issue #11005: [FLINK-15838] Dangling
CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581618802
The Azure build is failing due to test failure, already being tracked at FLINK-15811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] ayushtkn commented on issue #11005: [FLINK-15838] Dangling
CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581787826
Hi @leventov that completely makes sense. In Apache Hadoop too, if the method return value is ignored we get a checkstyle warning in the build report, but the checkstyles in hadoop, doesn't fail the build. So, in some cases where the response isn't of any use, only the execution of the method is important, then in that case the committer has the liberty to ignore the checkstyle warning.
But in Flink the build itself will fail, so cases where the response of the method isn't needed just the execution is important it can create problem.
if you say we can create a follow-up jira for this rule integration and discuss..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11005: [FLINK-15838] Dangling
CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581578999
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 (Mon Feb 03 19:30:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11005: [FLINK-15838]
Dangling CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581588915
<!--
Meta data
Hash:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147267156 TriggerType:PUSH TriggerID:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509
Hash:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4800 TriggerType:PUSH TriggerID:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509
-->
## CI report:
* ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147267156) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4800)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leventov edited a comment on issue #11005: [FLINK-15838]
Dangling CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
leventov edited a comment on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581784038
It would be good to follow a systemic approach. What prevents introducing the same bugs in the future?
In Apache Druid, we use IntelliJ IDEA inspections as a part of the CI process.
@ccaominh created an image that could be integrated with Travis CI: https://github.com/ccaominh/intellij-inspect. See https://github.com/apache/druid/pull/9179 for details.
On the IntelliJ inspections level, checking this issue is a matter of adding CountDownLatch.await in the configuration of "Result of method call ignored" pattern and setting it to ERROR severity level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leventov commented on issue #11005: [FLINK-15838] Dangling
CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
leventov commented on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581784038
It would be good for having a systemic approach. What prevents introducing the same bugs in the future?
In Apache Druid, we use IntelliJ IDEA inspections as a part of CI process.
@ccaominh created an image which could be integrated with Travis CI: https://github.com/ccaominh/intellij-inspect. See https://github.com/apache/druid/pull/9179 for details.
On IntelliJ inspections level, checking this issue is a matter of adding CountDownLatch.await in the configuration of "Result of method call ignored" pattern and setting it to ERROR severity level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #11005: [FLINK-15838]
Dangling CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11005: [FLINK-15838] Dangling
CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581588915
<!--
Meta data
Hash:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ed9d65ffd90a04761fe3f941e6f2e22cd1afe509
-->
## CI report:
* ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11005: [FLINK-15838]
Dangling CountDownLatch.await(timeout)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11005: [FLINK-15838] Dangling CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581588915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed9d65ffd90a04761fe3f941e6f2e22cd1afe509",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/147267156",
"triggerID" : "ed9d65ffd90a04761fe3f941e6f2e22cd1afe509",
"triggerType" : "PUSH"
}, {
"hash" : "ed9d65ffd90a04761fe3f941e6f2e22cd1afe509",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4800",
"triggerID" : "ed9d65ffd90a04761fe3f941e6f2e22cd1afe509",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9d65ffd90a04761fe3f941e6f2e22cd1afe509 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147267156) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4800)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services