[GitHub] [rocketmq-spring] RongtongJin commented on a diff in pull request #554: [ISSUE #553] Feat: Integrate RocketMQ 5.0 client with Spring

["RongtongJin (via GitHub)" <gi...@apache.org>]

RongtongJin commented on code in PR #554:
URL: https://github.com/apache/rocketmq-spring/pull/554#discussion_r1186996434


##########
rocketmq-client-spring-boot-samples/rocketmq-client-producer-demo/src/main/java/org/apache/rocketmq/samples/springboot/domain/UserMessage.java:
##########
@@ -0,0 +1,37 @@
+package org.apache.rocketmq.samples.springboot.domain;
+
+/**
+ * @author Akai
+ */

Review Comment:
   Plz remove the author info.



##########
rocketmq-client-spring-boot-samples/LICENSE:
##########


Review Comment:
   It seems that this file is unnecessary.



##########
pom.xml:
##########
@@ -215,6 +215,9 @@
         <module>rocketmq-spring-boot-parent</module>
         <module>rocketmq-spring-boot</module>
         <module>rocketmq-spring-boot-starter</module>
+        <module>rocketmq-client-spring-boot</module>
+        <module>rocketmq-client-spring-boot-parent</module>
+        <module>rocketmq-client-spring-boot-starter</module>

Review Comment:
   It seems that the name of the module cannot be well distinguished from the original remoting client. Maybe rename o `rocketmq-grpc-client-spring-boot`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org