You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by huikyole <gi...@git.apache.org> on 2015/08/12 10:37:33 UTC

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

GitHub user huikyole opened a pull request:

    https://github.com/apache/climate/pull/223

    CLIMATE-564 - Managing multiple netcdf files stored on a local machine

    - A new file loader load_multiple_files can read netcdf files with common file name patterns.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huikyole/climate CLIMATE-564

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #223
    
----
commit 579c1f1384583abf83b4cb9c2b8e4eeb6c26bd19
Author: huikyole <hu...@argo.jpl.nasa.gov>
Date:   2015-08-12T08:34:44Z

    CLIMATE-564 - Managing multiple netcdf files stored on a local machine
    
    - A new file loader load_multiple_files can read netcdf files with common file name patterns.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/climate/pull/223


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on a diff in the pull request:

    https://github.com/apache/climate/pull/223#discussion_r36878401
  
    --- Diff: ocw/data_source/local.py ---
    @@ -268,3 +268,38 @@ def load_file(file_path,
     
         return Dataset(lats, lons, times, values, variable=variable_name,
                        units=variable_unit, name=name, origin=origin)
    +
    +def load_multiple_files(data_info):
    --- End diff --
    
    I'm not the biggest fan of passing info this way. The config related stuff should be handled in the proper package and necessary parameters should be passed into this function independent of the nested config format. Otherwise this becomes dependent upon the format of a config file that is subject to change and it's not terribly helpful to call when not using output from the config file.
    
    In other words
    * This requires output from a parsed config file to function, and that's confusing.
    * The format of the config file isn't specified here, so the user has no idea how to actually use this function unless they read the config related stuff. If they have to use the config stuff then this functionality should be in the config related code it would seem.
    * If/when the format of the config file changes this is subject to break, which is just poorly encapsulating functionality it seems.
    
    I think this would be much cleaner if this function had a defined interface that was independent of the config file instead of taking nested config output.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:

    https://github.com/apache/climate/pull/223#issuecomment-130217760
  
     Merged build triggered. Test Failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:

    https://github.com/apache/climate/pull/223#issuecomment-130217993
  
    Merged build finished. Test Passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:

    https://github.com/apache/climate/pull/223#issuecomment-131200659
  
    Merged build finished. Test Passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:

    https://github.com/apache/climate/pull/223#issuecomment-131200417
  
    Merged build started. Test Failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:

    https://github.com/apache/climate/pull/223#issuecomment-131200393
  
     Merged build triggered. Test Failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request: CLIMATE-564 - Managing multiple netcdf files...

Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:

    https://github.com/apache/climate/pull/223#issuecomment-130217783
  
    Merged build started. Test Failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---