You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/27 08:21:23 UTC
[GitHub] [incubator-doris] adonis0147 opened a new pull request, #9809: [feature-wip](array-type) Support array type which doesn't contain null
adonis0147 opened a new pull request, #9809:
URL: https://github.com/apache/incubator-doris/pull/9809
# Proposed changes
Issue Number: close #9808
## Problem Summary:
Please refer to #9808 .
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: Yes
3. Has document been added or modified: No
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9809: [feature-wip](array-type) Support array type which doesn't contain null
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9809:
URL: https://github.com/apache/incubator-doris/pull/9809#issuecomment-1146574529
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9809: [feature-wip](array-type) Support array type which doesn't contain null
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #9809:
URL: https://github.com/apache/incubator-doris/pull/9809#discussion_r886856398
##########
gensrc/thrift/Types.thrift:
##########
@@ -126,6 +126,9 @@ struct TTypeNode {
// only used for structs; has struct_fields.size() corresponding child types
3: optional list<TStructField> struct_fields
+
+ // only used for complex types, such as array, map and etc.
+ 4: optional bool contains_null
Review Comment:
use is_null or is_nullable instead of contains_null;
is_null means current scalar_type is null or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9809: [feature-wip](array-type) Support array type which doesn't contain null
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9809:
URL: https://github.com/apache/incubator-doris/pull/9809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9809: [feature-wip](array-type) Support array type which doesn't contain null
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9809:
URL: https://github.com/apache/incubator-doris/pull/9809#issuecomment-1151869883
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9809: [feature-wip](array-type) Support array type which doesn't contain null
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #9809:
URL: https://github.com/apache/incubator-doris/pull/9809#discussion_r886856398
##########
gensrc/thrift/Types.thrift:
##########
@@ -126,6 +126,9 @@ struct TTypeNode {
// only used for structs; has struct_fields.size() corresponding child types
3: optional list<TStructField> struct_fields
+
+ // only used for complex types, such as array, map and etc.
+ 4: optional bool contains_null
Review Comment:
use is_null or is_nullable instead of contains_null;
is_null means current scalar_type is null or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9809: [feature-wip](array-type) Support array type which doesn't contain null
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9809:
URL: https://github.com/apache/incubator-doris/pull/9809#issuecomment-1146574518
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org