You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Derek Chen-Becker (Jira)" <ji...@apache.org> on 2023/02/03 20:21:00 UTC
[jira] [Commented] (CASSANDRA-17708) Fix flaky testOutboundConnectionsAreRejectedWhenAuthFails
[ https://issues.apache.org/jira/browse/CASSANDRA-17708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684020#comment-17684020 ]
Derek Chen-Becker commented on CASSANDRA-17708:
-----------------------------------------------
This looks like a race condition and a bad assertion in the unit test. I'm looking at
testOutboundFallbackOnSSLHandshakeFailure
which touches the same code. In that method, we enqueue a message, initiate the connection, and then just wait for the outbound connection to become connected. At the point where the connection state is changed (allowing outboundConnection.isConnected() to return true), there's no guarantee that the message that force the connection would actually be flushed. I think that for the purpose of this unit test, checking for pending messages is not actually needed, or should potentially be in another test.
> Fix flaky testOutboundConnectionsAreRejectedWhenAuthFails
> ---------------------------------------------------------
>
> Key: CASSANDRA-17708
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17708
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
>
> testOutboundConnectionsAreRejectedWhenAuthFails was introduced in CASSANDRA-17661
> It seems it was introduced flaky from the very beginning as per this run in a loop - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=flaky-testOutboundConnectionsAreRejectedWhenAuthFails&filter=all]
> CC [~janaki.manchala] , [~jonmeredith], [~ycai]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org