You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/17 01:53:19 UTC
[GitHub] [tvm] monchin opened a new pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
monchin opened a new pull request #7461:
URL: https://github.com/apache/tvm/pull/7461
The codes for `operator++()` and `operator--()` are same, so I think it should be wrong and fixed it.
As I saw @junrushao1994 wrote it in githistory, please review it. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] monchin commented on pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
Posted by GitBox <gi...@apache.org>.
monchin commented on pull request #7461:
URL: https://github.com/apache/tvm/pull/7461#issuecomment-780247907
> Thanks for the fix. btw is that possible to add a unit test for this?
I'm sorry that I know it is a little stupid, but I actually don't quite know how to add a unittest. Do I just need to compile the fixed code and run `tests/cpp/container_test.cc`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7461:
URL: https://github.com/apache/tvm/pull/7461#issuecomment-780242231
Thanks for the fix. btw is that possible to add a unit test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7461:
URL: https://github.com/apache/tvm/pull/7461#issuecomment-780317623
The failed tests look unrelated. @comaniac any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7461:
URL: https://github.com/apache/tvm/pull/7461#issuecomment-780361674
> The failed tests look unrelated. @comaniac any ideas?
I guess it's due to timeout and result in no valid schedule, although it's unlikely to happen...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7461:
URL: https://github.com/apache/tvm/pull/7461#issuecomment-780964372
Thanks @monchin ! @junrushao1994 would be great to add a followup PR with unittest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7461:
URL: https://github.com/apache/tvm/pull/7461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7461:
URL: https://github.com/apache/tvm/pull/7461#issuecomment-780249591
That's the right place. You could modify an existing unit test or add a new test function to that file, so that the test will fail without the fixing you made. You can follow this document to run the test locally first before committing: https://tvm.apache.org/docs/contribute/pull_request.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #7461: [Bugfix] debug operator--() in include/tvm/node/container.h
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7461:
URL: https://github.com/apache/tvm/pull/7461#issuecomment-780363388
Let's retrigger the CI and add a unittest for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org