[GitHub] [beam] lostluck commented on a diff in pull request #26782: [#22737] Fit & Finish for Go SDK timer support.

["lostluck (via GitHub)" <gi...@apache.org>]

lostluck commented on code in PR #26782:
URL: https://github.com/apache/beam/pull/26782#discussion_r1213617691


##########
sdks/go/pkg/beam/core/runtime/exec/pardo.go:
##########
@@ -158,6 +161,7 @@ func (n *ParDo) ProcessElement(_ context.Context, elm *FullValue, values ...ReSt
 // a ParDo's ProcessElement functionality with their own construction of
 // MainInputs.
 func (n *ParDo) processMainInput(mainIn *MainInput) error {
+	n.TimerTracker.SetCurrentKey(mainIn)

Review Comment:
   I folded that check into the SetCurrentKey call itself instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org