You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by "Georg Kallidis (JIRA)" <ji...@apache.org> on 2011/09/08 12:21:10 UTC

[jira] [Updated] (TRB-85) Nested Templates output reversed

     [ https://issues.apache.org/jira/browse/TRB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Georg Kallidis updated TRB-85:
------------------------------

    Attachment: TurbineVelocityServices.patch

patche for current bug. patched method is only the method org.apache.turbine.services.velocity.TurbineVelocityService.handleRequest(Context, String, OutputStream). Another method (org.apache.turbine.services.velocity.TurbineVelocityService.handleRequest(Context, String)) uses a local writer object.

> Nested Templates output reversed
> --------------------------------
>
>                 Key: TRB-85
>                 URL: https://issues.apache.org/jira/browse/TRB-85
>             Project: Turbine
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: Core 4.0-M1
>         Environment: Windows XP, 
> java version "1.6.0_13"
> Java(TM) SE Runtime Environment (build 1.6.0_13-b03)
> Java HotSpot(TM) Server VM (build 11.3-b02, mixed mode)
> Tomcat 6.0.18_03
>            Reporter: Georg Kallidis
>         Attachments: TurbineVelocityServices.patch
>
>
> Using (nested) calls in screen template the output (of the templates) seems to be reversed, i.e. the latest called templates are outputted first (lifo). 
> This may be due to that org.apache.turbine.services.velocity.TurbineVelocityService.handleRequest(Context, String) is implemented such, that each invocation creates a new instance of a java.io.OutputStreamWriter.OutputStreamWriter(OutputStream, String), which velocity then is writing to. May be the exact reason should be investigated in more detail. No test is available at the moment.
> This could be solved by providing a concurrent safe instance variable of OutputStreamWriter to be used in this method (handleRequest).
> Cft. http://mail-archives.apache.org/mod_mbox/turbine-dev/201109.mbox/%3C4E67C58C.5020804@apache.org%3E
> A patch could be attached later ..

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira