You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by gs...@apache.org on 2001/01/19 10:19:53 UTC

cvs commit: apr-util/crypto apr_sha1.c

gstein      01/01/19 01:19:53

  Modified:    crypto   apr_sha1.c
  Log:
  add a missing type back in. this used to be AP_BYTE.
  
  Revision  Changes    Path
  1.22      +2 -0      apr-util/crypto/apr_sha1.c
  
  Index: apr_sha1.c
  ===================================================================
  RCS file: /home/cvs/apr-util/crypto/apr_sha1.c,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -u -r1.21 -r1.22
  --- apr_sha1.c	2001/01/19 07:02:02	1.21
  +++ apr_sha1.c	2001/01/19 09:19:53	1.22
  @@ -119,6 +119,8 @@
   
   #define SHA_BLOCKSIZE           64
   
  +typedef unsigned char apr_byte_t;
  +
   #if APR_CHARSET_EBCDIC
   static apr_xlate_t *ebcdic2ascii_xlate;
   
  
  
  

Re: cvs commit: apr-util/crypto apr_sha1.c

Posted by Greg Stein <gs...@lyra.org>.
why? because I hadn't reconfig'd in APR, so I didn't see the type in any .h
file. so I figured "an oopsy" and put the thing into the .c file.

IOW, my mistake :-)

I've reversed this.

Cheers,
-g

On Fri, Jan 19, 2001 at 06:39:15AM -0600, William A. Rowe, Jr. wrote:
> > gstein      01/01/19 01:19:53
> > 
> >   Modified:    crypto   apr_sha1.c
> >   Log:
> >   add a missing type back in. this used to be AP_BYTE.
> >   
> >   Revision  Changes    Path
> >   1.22      +2 -0      apr-util/crypto/apr_sha1.c
> 
> Why?
> 
> Please see apr.hw/apr.h.in.
>    
> >   Index: apr_sha1.c
> >   ===================================================================
> >   RCS file: /home/cvs/apr-util/crypto/apr_sha1.c,v
> >   retrieving revision 1.21
> >   retrieving revision 1.22
> >   diff -u -u -r1.21 -r1.22
> >   --- apr_sha1.c	2001/01/19 07:02:02	1.21
> >   +++ apr_sha1.c	2001/01/19 09:19:53	1.22
> >   @@ -119,6 +119,8 @@
> >    
> >    #define SHA_BLOCKSIZE           64
> >    
> >   +typedef unsigned char apr_byte_t;
> >   +
> >    #if APR_CHARSET_EBCDIC
> >    static apr_xlate_t *ebcdic2ascii_xlate;
> >    
> >   
> >   
> >   
> > 

-- 
Greg Stein, http://www.lyra.org/

RE: cvs commit: apr-util/crypto apr_sha1.c

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
> gstein      01/01/19 01:19:53
> 
>   Modified:    crypto   apr_sha1.c
>   Log:
>   add a missing type back in. this used to be AP_BYTE.
>   
>   Revision  Changes    Path
>   1.22      +2 -0      apr-util/crypto/apr_sha1.c

Why?

Please see apr.hw/apr.h.in.
   
>   Index: apr_sha1.c
>   ===================================================================
>   RCS file: /home/cvs/apr-util/crypto/apr_sha1.c,v
>   retrieving revision 1.21
>   retrieving revision 1.22
>   diff -u -u -r1.21 -r1.22
>   --- apr_sha1.c	2001/01/19 07:02:02	1.21
>   +++ apr_sha1.c	2001/01/19 09:19:53	1.22
>   @@ -119,6 +119,8 @@
>    
>    #define SHA_BLOCKSIZE           64
>    
>   +typedef unsigned char apr_byte_t;
>   +
>    #if APR_CHARSET_EBCDIC
>    static apr_xlate_t *ebcdic2ascii_xlate;
>    
>   
>   
>   
>