You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (Created) (JIRA)" <ji...@apache.org> on 2012/01/10 23:12:39 UTC
[jira] [Created] (CASSANDRA-3723) Include await for the queues in
tpstats
Include await for the queues in tpstats
---------------------------------------
Key: CASSANDRA-3723
URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
Project: Cassandra
Issue Type: Bug
Components: Tools
Affects Versions: 1.2
Reporter: Vijay
Assignee: Vijay
Priority: Minor
Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
await
The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187169#comment-13187169 ]
Vijay commented on CASSANDRA-3723:
----------------------------------
>>> latency = await + this task's processing time, right?
Currently it is just the processing time... what i am proposing is to change the latency number to something like await. (If that makes sense).
>>> not sure why we'd remove the latency though
I am not saying we have to remove it... Just like a enhancement instead of adding one more metric to glance :)
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3723) Include await for
the queues in tpstats
Posted by "Jonathan Ellis (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187273#comment-13187273 ]
Jonathan Ellis edited comment on CASSANDRA-3723 at 1/16/12 10:49 PM:
---------------------------------------------------------------------
I'm with Peter, I'd rather have wait time (which we can get from MDT.constructionTime) separate from latency.
Edit: and expose both.
was (Author: jbellis):
I'm with Peter, I'd rather have wait time (which we can get from MDT.constructionTime) separate from latency.
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3723:
--------------------------------------
Affects Version/s: (was: 1.2.0)
Issue Type: New Feature (was: Bug)
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.2.0
>
> Attachments: 0001-tp-queue-wait-jmx.patch
>
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187002#comment-13187002 ]
Vijay commented on CASSANDRA-3723:
----------------------------------
Any concern in changing the existing latency numbers with the await metrics? or should we just do this as a separate metric?
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3723:
-----------------------------
Attachment: 0001-tp-queue-wait-jmx.patch
added a small refactor on MDT and this patch adds the metric @ beforeExecute(Thread t, Runnable task)
Pool Name Active Pending Completed Blocked All time blocked Queue Wait(ms)
ReadStage 0 0 851359 0 0 0.000
Let me know, Thanks!
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-tp-queue-wait-jmx.patch
>
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3723) Include await for
the queues in tpstats
Posted by "Vijay (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187169#comment-13187169 ]
Vijay edited comment on CASSANDRA-3723 at 1/16/12 8:43 PM:
-----------------------------------------------------------
>>> latency = await + this task's processing time, right?
Currently it is just the processing time... what i am proposing is to change the latency number to something like await (wait time in the queue + processing time). If that makes sense.
>>> not sure why we'd remove the latency though
I am not saying we have to remove it... Just like a enhancement instead of adding one more metric to glance :)
was (Author: vijay2win@yahoo.com):
>>> latency = await + this task's processing time, right?
Currently it is just the processing time... what i am proposing is to change the latency number to something like await (await in the queue + processing time). If that makes sense.
>>> not sure why we'd remove the latency though
I am not saying we have to remove it... Just like a enhancement instead of adding one more metric to glance :)
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187273#comment-13187273 ]
Jonathan Ellis commented on CASSANDRA-3723:
-------------------------------------------
I'm with Peter, I'd rather have wait time (which we can get from MDT.constructionTime) separate from latency.
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3723) Include await for
the queues in tpstats
Posted by "Vijay (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187169#comment-13187169 ]
Vijay edited comment on CASSANDRA-3723 at 1/16/12 8:42 PM:
-----------------------------------------------------------
>>> latency = await + this task's processing time, right?
Currently it is just the processing time... what i am proposing is to change the latency number to something like await (await in the queue + processing time). If that makes sense.
>>> not sure why we'd remove the latency though
I am not saying we have to remove it... Just like a enhancement instead of adding one more metric to glance :)
was (Author: vijay2win@yahoo.com):
>>> latency = await + this task's processing time, right?
Currently it is just the processing time... what i am proposing is to change the latency number to something like await. (If that makes sense).
>>> not sure why we'd remove the latency though
I am not saying we have to remove it... Just like a enhancement instead of adding one more metric to glance :)
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187111#comment-13187111 ]
Jonathan Ellis commented on CASSANDRA-3723:
-------------------------------------------
latency = await + this task's processing time, right?
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3723:
-----------------------------
Attachment: (was: 0001-tp-queue-wait-jmx.patch)
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-tp-queue-wait-jmx.patch
>
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187107#comment-13187107 ]
Peter Schuller commented on CASSANDRA-3723:
-------------------------------------------
I'm very much +1 on await, including having it right there in tpstats (not just JMX), it's a very useful metric (not sure why we'd remove the latency though).
As for performance: There are several things I've thought of that I want that are potentially performance impactful, yet useful even if just probabilistically sampled. I think there's a case to be made for using (thread-local, to avoid synchronization) randomization and probabilities in collecting statistics. This is one such case, if indeed there is a significant performance impact to begin with.
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3723) Include await for the queues in
tpstats
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3723:
-----------------------------
Attachment: 0001-tp-queue-wait-jmx.patch
> Include await for the queues in tpstats
> ---------------------------------------
>
> Key: CASSANDRA-3723
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3723
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-tp-queue-wait-jmx.patch
>
>
> Something simillar to IOSTAT await, there is an additional over head not sure if we have to make an exception for this.... but i think this has a huge "+" while troubleshooting....
> await
> The average time (in milliseconds) for I/O requests issued to the request to be served. This includes the time spent by the requests in queue and the time spent servicing them
> or we can also have a simple average of time spent in the queue before being served.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira