You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by an...@apache.org on 2015/06/12 20:15:05 UTC

spark git commit: [SPARK-8330] DAG visualization: trim whitespace from input

Repository: spark
Updated Branches:
  refs/heads/master 19834fa91 -> 886040515


[SPARK-8330] DAG visualization: trim whitespace from input

Safeguard against DOM rewriting.

Author: Andrew Or <an...@databricks.com>

Closes #6787 from andrewor14/dag-viz-trim and squashes the following commits:

0fb4afe [Andrew Or] Trim input metadata from DOM


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/88604051
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/88604051
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/88604051

Branch: refs/heads/master
Commit: 88604051511c788d7abb41a49e3eb3a8330c09a9
Parents: 19834fa
Author: Andrew Or <an...@databricks.com>
Authored: Fri Jun 12 11:14:55 2015 -0700
Committer: Andrew Or <an...@databricks.com>
Committed: Fri Jun 12 11:14:55 2015 -0700

----------------------------------------------------------------------
 .../main/resources/org/apache/spark/ui/static/spark-dag-viz.js  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/88604051/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js b/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
index 7a0dec2..9fa53ba 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
@@ -140,7 +140,8 @@ function renderDagViz(forJob) {
 
   // Find cached RDDs and mark them as such
   metadataContainer().selectAll(".cached-rdd").each(function(v) {
-    var nodeId = VizConstants.nodePrefix + d3.select(this).text();
+    var rddId = d3.select(this).text().trim();
+    var nodeId = VizConstants.nodePrefix + rddId;
     svg.selectAll("g." + nodeId).classed("cached", true);
   });
 
@@ -150,7 +151,7 @@ function renderDagViz(forJob) {
 /* Render the RDD DAG visualization on the stage page. */
 function renderDagVizForStage(svgContainer) {
   var metadata = metadataContainer().select(".stage-metadata");
-  var dot = metadata.select(".dot-file").text();
+  var dot = metadata.select(".dot-file").text().trim();
   var containerId = VizConstants.graphPrefix + metadata.attr("stage-id");
   var container = svgContainer.append("g").attr("id", containerId);
   renderDot(dot, container, false);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org