You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/24 16:01:31 UTC
[GitHub] [maven] gzm55 opened a new pull request #353: [MVN-6919] fix wrapper windows cmd scripts
gzm55 opened a new pull request #353:
URL: https://github.com/apache/maven/pull/353
new maven-wrapper inherits 2 bugs for windows batch scripts:
* correct file ending for windows cmd scripts
* download.cmd should parse the config file
This pr is ported from https://github.com/takari/maven-wrapper/pull/161.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gzm55 commented on pull request #353: [MNG-6919] fix wrapper windows cmd scripts
Posted by GitBox <gi...@apache.org>.
gzm55 commented on pull request #353:
URL: https://github.com/apache/maven/pull/353#issuecomment-633256957
> please drop the gitattributes changes
can we make all the cmd scripts to `crlf` at the releasing stage?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gzm55 commented on a change in pull request #353: [MNG-6919] fix wrapper windows cmd scripts
Posted by GitBox <gi...@apache.org>.
gzm55 commented on a change in pull request #353:
URL: https://github.com/apache/maven/pull/353#discussion_r429654038
##########
File path: apache-maven/src/assembly/maven/bin/.gitattributes
##########
@@ -1,3 +0,0 @@
-mvn eol=lf crlf=input
Review comment:
@michael-o now there is no `apache-maven/src/assembly/maven/bin/mvn` file, so the original `gitattributes` is out of date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gzm55 commented on pull request #353: [MNG-6919] fix wrapper windows cmd scripts
Posted by GitBox <gi...@apache.org>.
gzm55 commented on pull request #353:
URL: https://github.com/apache/maven/pull/353#issuecomment-633356092
@michael-o
as @rfscholte comment in the issue, eol is fixed in assembly-plugin settings, so i revert the changes on all .gitattributes file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #353: [MNG-6919] fix wrapper windows cmd scripts
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #353:
URL: https://github.com/apache/maven/pull/353#discussion_r429658416
##########
File path: apache-maven/src/assembly/maven/bin/.gitattributes
##########
@@ -1,3 +0,0 @@
-mvn eol=lf crlf=input
Review comment:
Didn't notice this, so I withdraw my comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gzm55 closed pull request #353: [MNG-6919] fix wrapper windows cmd scripts
Posted by GitBox <gi...@apache.org>.
gzm55 closed pull request #353:
URL: https://github.com/apache/maven/pull/353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org